small mess after refactoring?

Bug #738390 reported by Krzysztof Sikorski
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Vineyard
Fix Released
Undecided
Unassigned

Bug Description

I accidentally spotted two small bugs in the code. Both look like remains from some refactoring, I'm attaching the diff/patch which seems to work for me - or at least mask the problems.

Revision history for this message
Krzysztof Sikorski (krzysztof-sikorski) wrote :
Revision history for this message
Christian Dannie Storgaard (cybolic) wrote :

Well caught! I've applied your patch and committed the changes.

Changed in vineyard:
status: New → Fix Committed
Revision history for this message
Christian Dannie Storgaard (cybolic) wrote :

Oh, did this cause any real issues? I haven't run into it myself so I'm wondering if I should push a new release.

Revision history for this message
Krzysztof Sikorski (krzysztof-sikorski) wrote :

I spotted the first one after installing "Worms: Reloaded" in a new prefix - it blocked the Programs page from loading.
The second one just surfaced after patching the first one, I have no idea if it caused a bug anywhere.

Here's the debug log if you need it:

DEBUG:root:Adding program "Worms Reloaded"
DEBUG:root:Adding program "Steam"
DEBUG:root:Adding program "Microsoft Visual C++ 2005 Redistributable"
DEBUG:root:Done. Returning list of menu entries.
Worms Reloaded
DEBUG:root:Found override "Steam App" for "Worms Reloaded"
Error occured
There was an error running the threaded function: local variable 'key_value' referenced before assignment
/home/rad/vineyard/vineyard/async.py:117
/home/rad/vineyard/vineyard/widgets/widget.py:67
/home/rad/vineyard/vineyard/widgets/programs.py:152
/home/rad/vineyard/python-wine/wine/programs.py:502
<type 'exceptions.UnboundLocalError'>: local variable 'key_value' referenced before assignment
None

Changed in vineyard:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.