Ensure compatiblity with launchpadlib 1.9.7

[Leonard Richardson]

Binary package hint: software-center

This bug is to track any changes that need to be made to this package
to make it compatible with launchpadlib 1.9.7, the version of
launchpadlib currently in Natty. Forgive the formal tone; I'm filing a
lot of these bugs at once.

In late February, I performed an audit of this project's code and
spoke on IRC with the project maintainer, so this should not be a huge
surprise. If Natty already contains a compatible version of your
package, just mark this bug "Fix Released".

If you have any questions, feel free to respond in this bug. For a
guide to the changes in Natty's launchpadlib, see this mailing list
message:

https://lists.launchpad.net/launchpad-users/msg06239.html

My audit turned up serious problems in the part of software-center that uses launchpadlib, but in IRC conversation mvo said that this was not a serious issue because that part of the application is hidden by default due to the lack of a good UI. The good news is that with the new version of launchpadlib, you should no longer need your own UI for getting a user's Launchpad credentials. It should be fairly straightforward to fix software-center so that the bits of the code that use launchpad can be enabled by default.

[Matthew Paul Thomas (mpt)]

I see that in trunk r2367 , softwarecenter/backend/launchpad.py still has "SERVICE_ROOT = EDGE_SERVICE_ROOT", and uses that for "login_with()". So I guess this should be fairly simple to fix.

[Launchpad Janitor (janitor)]

This bug was fixed in the package software-center - 5.1.9

---------------
software-center (5.1.9) precise; urgency=low

  [ Gabor Kelemen ]
  * lp:~kelemeng/software-center/bug926743:
    - Mark strings for translation, add translator comment where needed
      (LP: #926743)

  [ Michael Vogt ]
  * lp:~mvo/software-center/latest-recommender:
    - import latest recommender client
  * lp:~mvo/software-center/dynamic-region-menu:
    - allow dynamic template in the software-center.menu file, currently
      supported is ${CURRENT_REGION}. This allows to build a dynamic
      "Your region" menu once we actually tag packages with the region
      information
  * lp:~mvo/software-center/sca-video:
    - add the ability to display embedded videos in the application
      details view
  * lp:~mvo/software-center/multiple-screenshots:
    - add support for the display of multiple screenshots in the
      application details view, as provided by the software-center-agent
  * lp:~mvo/software-center/submit-review-hang-fix:
    - fix hang when submitting a review on precise
  * lp:~mvo/software-center/screenshots-sorting:
    - ensure the multiple screenshots are sorted properly when
      they come from the json API
  * lp:~mvo/software-center/sca-video-updates:
    - update the client to follow the server side changes for
      videos from software-center-agent
  * lp:~mvo/software-center/video-ui-reshuffle:
    - shuffle the video location around a bit in the view to
      ensure the user finds it more easily
  * increase dependency on python-apt for the required
    apt_pkg.DepCache.policy_priority() support
  * lp:~mvo/software-center/sca-debtags:
    - fix the debtags parsing from the software-center-agent
  * lp:~mvo/software-center/multiple-versions:
    - add support for multiple versions into software-center
  * lp:~mvo/software-center/fix-recommenations-details-clicks:
    - fix clickthru of details view recommendations after refactor
  * lp:~mvo/software-center/rfc3166-use-common-name:
    - ensure that "common_name" in rfc3166 is used when available
      to avoid political issues around the name of the region

  [ Kiwinote ]
  * data/ui/gtk3/css/*.css:
    - use 'px' suffixes as required by latest gtk
  * softwarecenter/ui/gtk3/views/appdetailsview.py:
    - replace ... and ' with their unicode eequivalents (LP: #844799)
  * softwarecenter/db/application.py:
    - don't crash if the version nr associated with a screenshot is None

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/recommender-service-url:
    - update to the correct production url for the recommender
      service
  * lp:~gary-lasker/software-center/import-latest-sreclient:
    - import latest recommender client
  * lp:~gary-lasker/software-center/recommendation:
    - implement the recommendations opt-in UI and flow, upload
      of the user profile data after opt-in, and display of
      per-application recommendations in the details view
  * lp:~gary-lasker/software-center/temp-disable-lobby-recommendations-view:
    - temporarily hide the lobby recommendations opt-in and display
      view pending rollout of the corresponding support on the
      production server
...