Language selection

[David Prieto]

Hi, I've just downloaded Kung Fu and I love its simplicity. However, all the videos I try to rip end up being in English because there doesn't seem to be any audio selection option.

Is this feature going to be implemented in upcoming releases?

[Jason Gerard DeRose (jderose)]

Thank you for your bug report.

Yes, language selection is my top priority for 0.2.0, which I'm sure your bug report will help motivate me to finish. ;)

By the way, what locale are you using? Is there a language track on your DVD that matches your locale?

The only reason I thought it okay to release the 0.1.x series without language selection is that I thought the 'current_audio' pad on dvddemux would default to something reasonable based on current locale, so that most people would get the audio they wanted most of the time. But maybe this isn't the case.

[David Prieto (frandavid100-gmail)]

"I'm sure your bug report will help motivate me to finish".

That honored me, really.

"By the way, what locale are you using? Is there a language track on your DVD that matches your locale?"

I'm using Spanish locale, and yeah the DVD I tried (Mallrats) does have a Spanish track.

"The only reason I thought it okay to release the 0.1.x series without language selection is that I thought the 'current_audio' pad on dvddemux would default to something reasonable based on current locale, so that most people would get the audio they wanted most of the time. But maybe this isn't the case".

No, I don't think it is, my DVDs play with Spanish voices in my home DVD but in English when I play them in Totem, so I'm not sure gnome sets any language rules for players to follow.

I really hope to see Kung Fu in Universe soon, I don't rip a lot of movies actually but it's so cool and simple that anyone who wants the task done should choose it.

In short, it rocks.

[Jason Gerard DeRose (jderose)]

David,

Okay, this is good to know (about the locale issues). In my opinion, it's extra not cool that the default audio track isn't being chosen based on the locale. For the way KungFu currently works, the problem lies strictly in the dvddemux element. For Totem, I don't know... it might be dvddemux or decodebin or playbin or even Totem itself that is selecting the audio track. I'll see what I can do about getting a patch together to at least fix this in GStreamer.

Thanks for the compliment! I'm not a MOTU yet. I've been submitted my packages on REVU, but until some MOTUs advocate it, there's not much I can do about getting KungFu into Universe (as far as I know).

KungFu could really use a Spanish translation, should you feel so inclined!

[Jason Gerard DeRose (jderose)]

Also, in the meantime you can use Thoggen, which is in Universe. Although I've taken a different approach on a number of things with KungFu, I still think that Thoggen is an excellent application.

[David Prieto (frandavid100-gmail)]

"KungFu could really use a Spanish translation, should you feel so inclined!"

Sure, you can take it for granted. I have never done that before, tho, so I'll need a little practice with gtranslator ^^

BTW and completely unrelated to the topic, I was messing around with Inkscape and I made some tango-ish (sorta) KungFu icons. Please find them attached just in case you like them.

[Jason Gerard DeRose (jderose)]

David,

Thanks a lot for the Spanish translation and improved icons!

For the sake of getting language selection into KungFu ASAP, I'm going to leave out some of the features that I was originally planning of for 0.2.0. So I expect that I'll have something ready this week.

[Jason Gerard DeRose (jderose)]

David,

I just pushed some language selection stuff to https://launchpad.net/people/jderose/+branch/kungfu/trunk

You can now select the language streams for what you rip, but it currently has these limitations:

1) It only affects the language on the resulting rip; it does not yet change the language played in the integrated preview player.
2) The default language isn't yet intelligently selected based on the locale.
3) The language is displayed only as its two letter ISO 639 code. I still need to figure out how to get the locale correct human readable name from this code.

I'll fix all this stuff before I release 0.2.0, but its there if you want to test it.

Especially once the above is fixed, I'd love to have someone who uses another locale give all this a good testing... hint, hint. ;)

Thanks again for all your help!

[Jason Gerard DeRose (jderose)]

Here's a pre-release package for testing.

[Jason Gerard DeRose (jderose)]

Okay, here's another pre-release package.

Now the translated language name is displayed in the combobox rather than the iso_639 code. And the default audio track will be chosen based on the locale (if a match is found).

The only thing left to do is to make the preview player uses the correct audio stream.

[Jason Gerard DeRose (jderose)]

Oops. That package was broken. Use this one. ;)

[Jason Gerard DeRose (jderose)]

Heck, that didn't take long.

The built-in player now plays the correct audio stream/language. However, switching streams after you have already started playing isn't working because of some gstreamer bugs. (The same thing happens in Totem).

Okay, probably no more pre-release packages today. ;)

[David Prieto (frandavid100-gmail)]

Hey Jason

Just seen your messages, I'll give it a try and tell you if it's working
fine or not.

I'm at my girlfriend's today and I'm afraid she hasn't got any DVDs, but
I'll rent some DVD or something later today and tell you if everything's
OK, right?

Take care mate!

El mié, 06-12-2006 a las 04:52 +0000, Jason Gerard DeRose escribió:
> Heck, that didn't take long.
>
> The built-in player now plays the correct audio stream/language.
> However, switching streams after you have already started playing isn't
> working because of some gstreamer bugs. (The same thing happens in
> Totem).
>
> Okay, probably no more pre-release packages today. ;)
>
> ** Attachment added: "Edgy package for KungFu 0.2.0.alpha4"
> http://librarian.launchpad.net/5254905/kungfu_0.2.0.alpha4-0ubuntu1_all.deb
>
> ** Changed in: kungfu (upstream)
> Status: In Progress => Fix Committed
>

[David Prieto (frandavid100-gmail)]

I can confirm that it works perfectly, I get a language selection dialog set to Spanish by default. Great work :-)

[Jason Gerard DeRose (jderose)]

I just released 0.2.0, which includes a fix for this bug.

http://jasonderose.org/kungfu/releases/