Stray raise Exception(image) prevents EC2 ModifyImageAttribute from working

Bug #736915 reported by Soren Hansen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Soren Hansen

Bug Description

Towards the end of modify_image_attribute, there's a spurious "raise Exception(image)" which I'm guessing is a leftover from debugging something. It renders ModifyImageAttribute broken.

Related branches

Soren Hansen (soren)
Changed in nova:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Soren Hansen (soren)
Revision history for this message
Rick Harris (rconradharris) wrote :

Interesting.

One thing I've wanted to add is a new "SPIKE" tag similar to FIXME and TODO.

The difference would be that HUDSON would reject commits with this in the patch. That could prevent issues like this, since you could add something like

# SPIKE(sirp): testing code

raise Exception('blah')

and guarantee that it never makes it into trunk. Thoughts?

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → 2011.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.