Lint should not check line length in .sql scripts

Bug #736713 reported by Stuart Bishop
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Wishlist
Stuart Bishop
pocket-lint
Fix Released
Medium
Unassigned

Bug Description

Some of our .sql scripts require long lines. We should turn off these checks as they are false positives.

Stuart Bishop (stub)
Changed in launchpad:
status: New → Triaged
importance: Undecided → Wishlist
assignee: nobody → Stuart Bishop (stub)
Revision history for this message
Curtis Hovey (sinzui) wrote :

This irks me as well. I was thinking of making this fix upstream in pocket-lint. "formatcheck.py" hushed long lines in logs by adding a language to the mime_type_language dict:
    'text/x-log': LOG,
Since these is no checker for that type, we do not get reports. I think we can add
    'text/x-sql': SQL,

We could add checker for common text file issues:
{{{
class SQLChecker(AnyTextChecker):
    ""Verify SQL style."""
    def check(self):
        """Call each line_method for each line in text."""
        for line_no, line in enumerate(self.text.splitlines()):
            line_no += 1
            self.check_trailing_whitespace(line_no, line)
            self.check_conflicts(line_no, line)
}}}

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
milestone: none → 11.04
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
tags: added: qa-untestable
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in pocket-lint:
status: New → Triaged
importance: Undecided → Medium
Curtis Hovey (sinzui)
Changed in pocket-lint:
milestone: none → 0.5.14
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
Curtis Hovey (sinzui)
Changed in pocket-lint:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in pocket-lint:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in pocket-lint:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.