Lint should not check line length in .sql scripts
Bug #736713 reported by
Stuart Bishop
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Wishlist
|
Stuart Bishop | ||
pocket-lint |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Some of our .sql scripts require long lines. We should turn off these checks as they are false positives.
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Wishlist |
assignee: | nobody → Stuart Bishop (stub) |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in pocket-lint: | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in pocket-lint: | |
milestone: | none → 0.5.14 |
assignee: | nobody → Curtis Hovey (sinzui) |
status: | Triaged → In Progress |
Changed in pocket-lint: | |
status: | In Progress → Fix Committed |
Changed in pocket-lint: | |
status: | Fix Committed → Fix Released |
Changed in pocket-lint: | |
assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
This irks me as well. I was thinking of making this fix upstream in pocket-lint. "formatcheck.py" hushed long lines in logs by adding a language to the mime_type_language dict:
'text/x-log': LOG,
Since these is no checker for that type, we do not get reports. I think we can add
'text/x-sql': SQL,
We could add checker for common text file issues: AnyTextChecker) : self.text. splitlines( )):
self. check_trailing_ whitespace( line_no, line)
self. check_conflicts (line_no, line)
{{{
class SQLChecker(
""Verify SQL style."""
def check(self):
"""Call each line_method for each line in text."""
for line_no, line in enumerate(
line_no += 1
}}}