[stormyfacts] fix behaviour of alert factoids with prefixes

Bug #735804 reported by m4v
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu IRC Bots
Fix Released
Medium
Unassigned

Bug Description

in Encyclopedia calling for "!foo lots of text" triggers ubottu's iamnotsmart reply. Stormyfacts does the same *except* for factoids with the +alert tag (such as !ops)
originally I thought this would help users that forget to use the pipe char, but after a while of looking at #ubuntu I see now the people that forget it the most are actually trying to disrupt the channel, this change would make them even more disruptive.

Gotta remember to change it back to how it was.

Tags: stormyfacts
Changed in ubuntu-bots:
assignee: mav (m4v) → m4v (symphony)
Revision history for this message
m4v (m4v) wrote :

Noticed that #debian uses the !ops call without the pipe, so It could be useful to make it work in #ubuntu as well, people idling in both channels won't have to think which channel is needs the pipe and which don't.
Also factoid calls have a length check now, maybe the abuse won't so bad now and this bug can be set as wontfix.

Ask ops what they would like better.

Changed in ubuntu-bots:
assignee: m4v (m4v) → nobody
Revision history for this message
m4v (m4v) wrote :

as a clarification to those that have not seen/read our email to -irc yet. All factoids needs the pipe for prefix text:
 * !foo | asd asd asd (will work)
 * !foo asd asd asd (will not work)
the only exception is when the prefixed text is a nick:
 * !foo nick (in this case not using the pipe will work)

This bug is for the special case of allowing "!ops asd asd asd" to work.

Revision history for this message
m4v (m4v) wrote :

I made it so "!ops asd asd asd" sends an alert but nothing else, this is a middle ground between making the command work normally or send a failure reply like in Encyclopedia.

Changed in ubuntu-bots:
status: Confirmed → Fix Committed
m4v (m4v)
Changed in ubuntu-bots:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.