Blank to theme shows Image if theme by song

[Jonathan Corwin]

I have OpenLP configured for song level themes.
Add a song and an image to the service.
Go live on the song. Then click blank to theme.
Then go live on the image, it displays the image. I would expect it to display the service theme background. (or global if no service theme). It should only show the image once I unblank.

Sort of relatedish to this is the fact that not being able to Close a song in V2 means we can't change from a song specific theme back to service theme using the blank to theme button. Perhaps we need an [x] somewhere although this is clutter we're trying to avoid.

[Tim Bentley (trb143)]

Looked at this and the problem seems to be in the Javascript code.
MainDisplay.displayImage sets the image and a background theme will not be shown.
If the theme has an image for it's background everything works fine.

Just have images for your themes and problem solved.

[Jonathan Corwin (j-corwin)]

Tim:
If I comment out lines 625->628 in slidecontroller.py, then all seems to work OK as far as this bug report is concerned.
Do you know why that code is there? What will break if it's removed?

                    # If current slide set background to image
                    if framenumber == slideno:
                        self.serviceItem.bg_image_bytes = \
                            self.parent.renderManager.image_manager. \
                            get_image_bytes(frame[u'title'])