Launchpad itself

API fails to render timeout errors

Bug #733293 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Leonard Richardson
Launchpad itself 11.04
lazr.restful
Fix Released
Critical
Unassigned

Bug Description

OOPS-1896STAGING145 shows that timeouts are not being rendered (maybe)

This issue appears to relate to 0.17.02 or 0.17.03 of lazr.restful. Maybe timeout errors raised by Lp need to be exposed?

Related branches

lp:~leonardr/lazr.restful/handle-view-that-provides-no-status
Benji York (community): Approve (code)
Diff: 0 lines
lp:~leonardr/launchpad/lazr.restful-0.17.5
Leonard Richardson (community): Approve
Diff: 12 lines (+1/-1)
1 file modified
versions.cfg (+1/-1)
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 733293] [NEW] API failes to render timeout errors

See also https://bugs.launchpad.net/launchpad/+bug/716174 which asks
that the errors sent back should actually be readable by the client
library rather than effectively opaque html.

Martin

Revision history for this message
Robert Collins (lifeless) wrote : Re: API failes to render timeout errors

Marking critical in lazr.restful too, though AIUI its not known yet whether its an issue in lazr.restful or not.

Changed in lazr.restful:
status: New → Triaged
importance: Undecided → Critical
Revision history for this message
Leonard Richardson (leonardr) wrote :

I'd say it's a problem in lazr.restful. We're assuming that when an exception can be adapted to a view, It's a view that has a .status associated with it. We should either handle the case where there is no status, or create a new interface that defines 'status' and only handle exceptions that can be adapted to _that_ sort of view.

Looking into this now.

William Grant (wgrant)
summary: - API failes to render timeout errors
+ API fails to render timeout errors
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12603 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12603>.

tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Leonard Richardson (leonardr)
Changed in launchpad:
status: Fix Committed → Fix Released
Changed in lazr.restful:
status: Triaged → Fix Released
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Released → Fix Committed
Robert Collins (lifeless)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.