uninformative error when invalid instance id is entered

[Cam Macdonell]

I accidentally ran

euca-terminate-instances i-i

instead of i-1. The error is an uninformative "unknown error". Only after a few minutes did I notice my typo

The problem is in api/ec2/cloud.py at line 78, wrapping a try/except as follows will provide a more intuitive message

def ec2_id_to_id(ec2_id):
    """Convert an ec2 ID (i-[base 16 number]) to an instance id (int)"""
    try:
        id = int(ec2_id.split('-')[-1], 16)
    except ValueError:
        raise exception.ApiError(_('invalid instance id: %s') % ec2_id)
    return id

[John Tran (jtran)]

This may have been fixed in another bug ticket? I am not able to reproduce the problem.

$ euca-terminate-instances i-1
InstanceNotFound: Instance i-00000001 not found

[John Tran (jtran)]

I've made a unit test for terminate_instances and linked the branch, in case it helps.

[Cam Macdonell (cam-cs)]

I saw the bug was fixed in Cactus. So this bug would only apply to Bexar.

Cam

On 2011-03-30 2:22 PM, "John Tran" <email address hidden> wrote:

I've made a unit test for terminate_instances and linked the branch, in
case it helps.

** Branch linked: lp:~jtran/nova/lp732902

--
You received this bug notification because you are a direct subscriber
of the bug.
https://bugs...

[Thierry Carrez (ttx)]

Marking as already fixed in Cactus.