Launchpad itself

migrate google search service to lp.services.search

Bug #729200 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Unassigned
Launchpad itself 11.03

Bug Description

Move the google search integration code to lp.services.search before fixing bug 267852.

Related branches

lp:~sinzui/launchpad/search-oopses-0
Curtis Hovey (community): Approve (code)
Diff: 519 lines (+79/-58)
18 files modified
buildout.cfg (+1/-1)
lib/canonical/config/schema-lazr.conf (+2/-2)
lib/canonical/launchpad/ftests/test_system_documentation.py (+0/-6)
lib/canonical/launchpad/scripts/runlaunchpad.py (+1/-1)
lib/canonical/launchpad/testing/tests/test_googleservice.py (+1/-1)
lib/canonical/launchpad/utilities/__init__.py (+0/-1)
lib/canonical/launchpad/zcml/configure.zcml (+0/-1)
lib/canonical/testing/layers.py (+17/-23)
lib/lp/app/browser/root.py (+1/-1)
lib/lp/app/browser/tests/launchpad-search-pages.txt (+1/-1)
lib/lp/services/configure.zcml (+1/-0)
lib/lp/services/search/configure.zcml (+7/-7)
lib/lp/services/search/doc/google-searchservice.txt (+6/-6)
lib/lp/services/search/doc/google-service-stub.txt.disabled (+1/-1)
lib/lp/services/search/google.py (+1/-1)
lib/lp/services/search/tests/googleserviceharness.py (+2/-2)
lib/lp/services/search/tests/test_doc.py (+35/-0)
lib/lp/services/search/tests/test_googleharness.py (+2/-3)
Curtis Hovey (sinzui)
Changed in launchpad:
status: In Progress → Fix Committed
tags: added: qa-ok
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 729200] Re: migrate google search service to lp.services.search

Could we at least call it 'googlesearch' there, not 'search' which is
/terribly/ generic.

Revision history for this message
Curtis Hovey (sinzui) wrote :

The intent for lp.services.search is to be generic. We never intended to be bound to Google or use just Google. I can rename it, but what should I rename lp.services.googlesearch.google to?

Revision history for this message
Robert Collins (lifeless) wrote :

On Sun, Mar 6, 2011 at 11:18 AM, Curtis Hovey
<email address hidden> wrote:
> The intent for lp.services.search is to be generic. We never intended to
> be bound to Google or use just Google. I can rename it, but what should
> I rename lp.services.googlesearch.google to?

I guess I just don't expect /anything/ in common with our other search
technologies, nor with future plans. I also don't like really deep
namespaces unless they add significant value: I was proposing that
rather than lp.services.search.google it just be
lp.services.googlesearch.

Its not a biggie any which way, just a preference that we don't bind
things together that aren't tightly related.

-Rob

Revision history for this message
Curtis Hovey (sinzui) wrote :

I will change the namespace in my second branch to remove spurious oopses from search.

Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.