2.0 - unable to clone action trigger event definitions

[Ben Shum]

Evergreen version: 2.0.1
OpenSRF version: 1.6.2
PostgreSQL version: 8.4
Linux distribution: Ubuntu Lucid 10.04

When using the notifications / action triggers interface and attempting to clone an existing event definition into a new one, we seem to be losing certain pieces of information along the way. The hook, reactor, and validator fields are "cloned" empty and filling these in with the original entries doesn't result in a successful cloning (it appears that the environment and parameters do not copy successfully either).

Checking our syslog entries, we have not seen any indication of the source of this problem, but will continue experimenting.

[Ben Shum (bshum)]

One other common issue I'm seeing (regardless of having the various hook, reactor, validator fields copied) during cloning is that the field to enter granularity is not shown at all. The label is there, but the actual field for entry is not.

I tested this behavior on a fresh install of Evergreen 2.0 with a clean DB and the stock A/T event definitions. I was unable to consistently clone triggers with that either; though I did notice that I was able to clone A/T events with a validator set of "NOOP_True". Any other one of the defaults A/Ts I chose failed, such as with validator "CircIsOverdue" or "HoldIsAvailable".

Will continue with additional testing...

[Dan Scott (denials)]

To comment on the original bug, the hook / reactor / validator fields are not getting cloned because _makeClonePane in openils/widget/AutoGrid.js is grabbing the display value of the original field ("checkout.due") instead of the integer value of the original field (4) and trying to set the value of the cloned field to the display value.

This suggests that the clone function might be significantly flawed elsewhere, as well?

[Dan Scott (denials)]

Checked in r19590 using a fix suggested by Bill Erickson in IRC. This corrects the cloning problem for the base fields, but Granularity still isn't cloned. However, you can edit "Granularity" after the object has been cloned and saved.