Browse DateIndex Broken for edge cases, displays wrong date

[Elizabeth Leddy]

Running 2.3.15
Test date: 2011-01-01
Part 1: Dates that are in the first month of the year (e.g. 2011-01-01) make the browse index page break because the modulo returns 0, which is then fed to DateTime and barfs.
Part 2: The year is incorrect for the same test date. I see the logic in how its being calculated and I think that this is a precision error, although I didn't spend a lot of time investigating and there is some dubiousness. I tested with a wide range though and the patch seems at least more correct than the current display value.

Patch for both issues will be attached

[Jim Baack (jbaack)]

Elizabeth-

Thanks for posting - I just ran into the bug too, saw a few very old posts about it and am surprised it isn't yet fixed. I think this version may be slightly more accurate.

Jim

            <dtml-var "DateTime(((_['sequence-key'] - 44640) / 535680),
                                ((_['sequence-key'] - 1440) / 44640 ) % 12 or 12,
                                (_['sequence-key'] / 1440 ) % 31 or 31,
                                (_['sequence-key'] / 60 ) % 24,
                                (_['sequence-key'] ) % 60,
                                0, 'UTC')">

[Hanno Schlichting (hannosch)]

I committed Jim's patch to ZCatalog trunk.

[Tres Seaver (tseaver)]

Released with Products.ZCatalog 3.0b2.