ZCML move breaks incoming mail

[William Grant]

The rename of script.zcml to zcml/script.zcml caused its inclusion of ../+*.zcml to fail to match production's incoming mail ZCML. An extra ../ is required.

[Julian Edwards (julian-edwards)]

Why didn't any tests break?

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12507 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12507>.

[Tim Penhey (thumper)]

Because we don't test for the inclusion of files outside the tree.

[Julian Edwards (julian-edwards)]

Oh right, it wasn't obvious it was outside the tree. That sucks :(

[Jonathan Lange (jml)]

I guess we could test this, since it's important. We could create a file in the directory above root during the test process and see if it gets included (and then delete the file, naturally).

[Robert Collins (lifeless)]

On Thu, Mar 3, 2011 at 9:55 PM, Jonathan Lange <email address hidden> wrote:
> I guess we could test this, since it's important. We could create a file
> in the directory above root during the test process and see if it gets
> included (and then delete the file, naturally).

That would play very poorly during parallel testing. Better to remove
the file altoghether by using host based auth of some sort - e.g.
identd.

-Rob

[Henning Eggers (henninge)]

This was expected to happen again, see bug 698299.