accept quilt returning "2" as success

Bug #727299 reported by Jelmer Vernooij
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jelmer Vernooij
bzr-builder
Fix Released
High
Jelmer Vernooij
Baltix
Invalid
Undecided
Unassigned

Bug Description

quilt will exit with 2 rather than 0 if everything was successful but e.g a particular patch was not in series. bzr-builder should not abort in this case.

Related branches

Jelmer Vernooij (jelmer)
Changed in bzr-builder:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Jelmer Vernooij (jelmer)
Jelmer Vernooij (jelmer)
Changed in bzr-builder:
status: In Progress → Fix Committed
Jelmer Vernooij (jelmer)
Changed in bzr-builder:
milestone: none → 0.7
Jelmer Vernooij (jelmer)
Changed in bzr-builder:
status: Fix Committed → Fix Released
Revision history for this message
Mantas Kriaučiūnas (mantas) wrote :

Jelmer Vernooij (jelmer) on 2011-06-14
>Changed in bzr-builder:
>status: Fix Committed → Fix Released

This bug still isn't fixed in launchpad.net recipes, see https://launchpadlibrarian.net/75436123/buildlog.txt.gz :
Log ends with error (was building from revision 4 'lp:~baltix/+junk/irrlicht-test'):
Building tree.
Retrieving 'lp:~baltix/+junk/irrlicht-test' to put at '/home/buildd/build-e448bd6a152da0c689ba50a12f130f389b95c050/chroot-autobuild/home/buildd/work/tree/recipe-{debupstream}20110718-0~{revno}'.
Applying quilt patches
File series fully applied, ends at patch debian/link-against-needed-libs.diff
bzr: ERROR: Failed to apply quilt patches

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

The new bzr-builder has not yet been deployed on Launchpad; that is still in progress.

Revision history for this message
aeoril (aeoril) wrote :

Is there a workaround? I have a brand new build/package built from scratch using the Gnu Autotools and dh_make/debuild following the tutorials in the Wiki's for beginners, and got this exact error. My build worked as native with a recipe, but when I switched to quilt, it started having this error. Works fine on my PC. Thanks in advance for any pointers.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I would recommend just keeping your package native for the moment - bzr-builder at its current version will try to convert your package to native before it does any building anyway (and that's what's failing here).

Revision history for this message
Patrick Pfeifer (patrick2000) wrote :

there is a workaround:
 - add the following line to the end of debian/patches/series:
zz_dummy
 - create an empty file debian/patches/zz_dummy
 - bzr push lp:~username/+junk/projectname
 - in your receipt, merge this branch in by adding the following line to the end of the receipt
merge quiltdummy lp:~patrick2000/+junk/tmux

for a working example, see
https://code.launchpad.net/~patrick2000/+recipe/tmux
http://bazaar.launchpad.net/~patrick2000/+junk/tmux/revision/14

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

A simpler workaround is to just remove the debian/patches directory if you don't have any patches.

Revision history for this message
Mantas Kriaučiūnas (mantas) wrote :

I still can't build recipes in launchpad.net when source is with quilt patches:

Recipe contents
# bzr-builder format 0.3 deb-version {debupstream}-1
lp:debian/theunarchiver

Error is the same:
Applying quilt patches
File series fully applied, ends at patch remove-extra-period
bzr: ERROR: Failed to apply quilt patches

See build log at https://code.launchpad.net/~baltix-members/+archive/ppa/+recipebuild/113642

Jelmer Vernooij (jelmer)
Changed in launchpad:
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

the new bzr-builder hasn't landed on launchpad yet

Changed in launchpad:
assignee: nobody → Jelmer Vernooij (jelmer)
William Grant (wgrant)
Changed in launchpad:
importance: Medium → High
Curtis Hovey (sinzui)
Changed in baltix:
status: New → Invalid
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

A new bzr-builder with this fix has now been deployed to the launchpad buildds.

Changed in launchpad:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.