flag-expired-memberships can trip an assertion check

[Curtis Hovey]

sendExpirationWarningEmail will raise an AssertionError (This membership's expiration date must be in the future) if the date changes will processing the list of memberships in flag-expired-memberships.py Both are working this dates in the same manner. This is just an issue minutes passing between when the membership is selected and when the method is called.

One way to way to deal with this would be to pass a kwarg to disable the check. flag-expired-memberships.py is the only call site for this method We could remove the assertion.

I am marking this critical because false warning require investigation.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12500 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12500) by a commit, but not testable.