voucher currency-related issues
Bug #726296 reported by
Albert Cervera i Areny - http://www.NaN-tic.com
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
Fix Released
|
Low
|
OpenERP R&D Addons Team 3 | ||
Bug Description
Processing a voucher which has currency_id field set to NULL will crash. This is reasonable but what should happen in the first place is that currency_id should be a required field.
Also, at one point the module uses "==" comparison to compare two float values instead of res.currency's is_zero() function.
The attached patch fixes both issues.
Related branches
lp:~openerp-dev/openobject-addons/trunk-bug-726296-ara
- OpenERP buildbot (community): Disapprove
- Mustufa Rangwala (Open ERP) (community): Approve
- qdp (OpenERP): Pending requested
-
Diff: 88 lines (+9/-8)4 files modifiedaccount_voucher/account_voucher.py (+3/-2)
account_voucher/account_voucher_view.xml (+1/-1)
account_voucher/voucher_payment_receipt_view.xml (+3/-3)
account_voucher/voucher_sales_purchase_view.xml (+2/-2)
Revision history for this message
| Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan) wrote | #1 |
| Changed in openobject-addons: | |
| assignee: | nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3) |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| Changed in openobject-addons: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Ashvin Rathod (OpenERP) (ara-tinyerp) wrote | #2 |
| Changed in openobject-addons: | |
| status: | In Progress → Fix Committed |
| Changed in openobject-addons: | |
| milestone: | none → 6.1 |
| Changed in openobject-addons: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hello Albert Cervera,
Its fix in lp:~openerp-dev/openobject-addons/trunk-bug-726296-ara branch. It will be merge soon with trunk addons.
Thanks for contribution.
Revision ID: <email address hidden>
Revision No: 4547
Thanks,
ara