missing param in /artefact/file/form/elements/filebrowser.php

Bug #725481 reported by Heinz Krettek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
François Marier

Bug Description

Hi,

there is a missing param in /artefact/file/form/elements/filebrowser.php

function pieform_element_filebrowser_get_path($folder) {
    $path = array();
    if ($folder) {
        $folders = ArtefactTypeFileBase::artefactchooser_folder_data(artefact_instance_from_id($folder))->data;
        $f = $folder;
        while ($f) {
            $path[] = (object) array('title' => $folders[$f]->title, 'id' => $f);
            $f = $folders[$f]->parent;
        }
    }

    $path[] = (object) array('title' => get_string('home'), 'id' => 0);
    return $path;
}

needs a get_string('home') , 'artefact.file') to use the "home" var

in artefact.file.php
$string['home'] = 'Stammverzeichnis';

Cheers
Heinz

Revision history for this message
François Marier (fmarier) wrote :

Good catch. Thanks for that Heinz!

Changed in mahara:
status: New → Fix Committed
importance: Undecided → Low
assignee: nobody → François Marier (fmarier)
milestone: none → 1.4.0
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.