vineyard-preferences fails to start when not in debug mode

Bug #725087 reported by Krzysztof Sikorski
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Vineyard
Fix Released
Undecided
Unassigned

Bug Description

The latest revision (#268) fails to start when it's not in debug mode, and gives an exception in debug mode.

The normal launch ends with IndexError:

rad@reyka:~/vineyard$ ./vineyard-preferences
Traceback (most recent call last):
  File "./vineyard-preferences", line 687, in <module>
    if sys.argv[1] == '--create-profile':
IndexError: list index out of range

Debug launch shows an error, but the GUI appears and it seems to function normally (I tried browsing the options and running an app):

rad@reyka:~/vineyard$ ./vineyard-preferences --debug=debug
Traceback (most recent call last):
  File "./vineyard-preferences", line 407, in __configuration_changed
    wine.prefixes.use(selected)
  File "/home/rad/vineyard/python-wine/wine/prefixes.py", line 395, in use
    prefix_data = get_metadata_from_name_or_prefix(prefix_name_or_path)
  File "/home/rad/vineyard/python-wine/wine/prefixes.py", line 386, in get_metadata_from_name_or_prefix
    if prefix_name_or_path.startswith('/') and os.path.exists(prefix_name_or_path):
AttributeError: 'NoneType' object has no attribute 'startswith'

Revision history for this message
Christian Dannie Storgaard (cybolic) wrote :

Thanks, I'll fix it. Things are a bit rough in trunk right now so expect breakage.

Changed in vineyard:
status: New → In Progress
Revision history for this message
Christian Dannie Storgaard (cybolic) wrote :

Fixed in #269.

Changed in vineyard:
status: In Progress → Fix Committed
Revision history for this message
Krzysztof Sikorski (krzysztof-sikorski) wrote :

I pulled #269 and I there is no error in debug mode, but the IndexError still happen.
And now I realise these are two separate errors - the IndexError is not related to the debug mode, it happens whenever you launch vineyard-preferences without any command line parameters.

Revision history for this message
Christian Dannie Storgaard (cybolic) wrote :

Ah, not all files were included in #269, sorry.
#270 includes the changes.

Changed in vineyard:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.