Negative gas mass causes floating exception in Satellite_Merging_Sizes_Covington2008

Bug #724472 reported by Andrew Benson
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Galacticus
Won't Fix
Medium
Andrew Benson

Bug Description

(From Luiz Felippe Rodrigues:) Under very specific conditions, I obtained a negative remnantRadius, making the code crash after trying to compute the squareroot of a negative number (for the remnantCircularVelocity). Crash happens using a modified version of Galacticus - not yet reproduced in the main branch.

Tags: crash merging

Related branches

Revision history for this message
Andrew Benson (abenson) wrote :

I've committed a revision (r315) which should catch problems such as this one and report a suitable error message. This doesn't fix the problem, but should hopefully give some insight into what's causing it.

Revision history for this message
Andrew Benson (abenson) wrote :

Seems to be fixed by existing revisions which catch cases where the gas mass in a component drops below zero due to numerical inaccuracies.

Changed in galacticus:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.