versioncontrol plugin crash at shutdown

[KSSG]

While looking at the debug output of Zim for another bug, I noticed this at shutdown:

DEBUG: Sending to child 2991: ["quit",[],{}]

DEBUG: Daemon replied: null
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/zim/plugins/versioncontrol/__init__.py", line 104, in on_quit
    self.autosave()
  File "/usr/lib/pymodules/python2.6/zim/plugins/versioncontrol/__init__.py", line 150, in autosave
    assert self.vcs
AssertionError

I am unsure of how this affects version control as I haven't tried to restore anything recently, but I thought of notifying just in case...please mark this as notfix if I didn't proceed correctly.
This is with Zim 0.50.

[Jaap Karssenberg (jaap.karssenberg)]

Don't see this error myself. Are you using versioncontrol, plugin enabled / used ?

[Launchpad Janitor (janitor)]

[Expired for Zim because there has been no activity for 60 days.]

[Robin Lee (cheeselee)]

The same issue reported by Fedora users:
https://bugzilla.redhat.com/show_bug.cgi?id=726671
https://bugzilla.redhat.com/show_bug.cgi?id=723285

But they both have no idea of reproducing this issue.

[Robin Lee (cheeselee)]

This issue persists in version 0.53.
New report by Fedora user:
https://bugzilla.redhat.com/show_bug.cgi?id=740337

[Robin Lee (cheeselee)]

Comment from a reporter:

I have enabled following plugins:
Calender
Inline-Calender
Insert symbol
line sorter
print to browser
Tags
Task list
Tray icon
version control

I de-selected version control but the zim still crashed while closing

[Robin Lee (cheeselee)]

This issue persists in version 0.54.
New report by Fedora user:
https://bugzilla.redhat.com/show_bug.cgi?id=783254

[Robin Lee (cheeselee)]

This issue persists in version 0.57.
New report by Fedora user:
https://bugzilla.redhat.com/show_bug.cgi?id=865078

[Jaap Karssenberg (jaap.karssenberg)]

On Thu, Oct 11, 2012 at 9:55 AM, Robin Lee <email address hidden> wrote:
> This issue persists in version 0.57.
> New report by Fedora user:
> https://bugzilla.redhat.com/show_bug.cgi?id=865078
>
> ** Bug watch added: Red Hat Bugzilla #865078
> https://bugzilla.redhat.com/show_bug.cgi?id=865078

I think this is a different issue - looks like an issue in setup of
the new IPC framework. So should go to separate report in my opinion.

Would need more context to know what zim processes are running and
which action triggered this new process to be started.

Regards,

Jaap

[Jaap Karssenberg (jaap.karssenberg)]

Hitting myself in the head - issue is triggered when attempting to autosave when plugin is enabled but notebook does not have version control.

Patch:

< assert self.vcs

> if not self.vcs:
> return

[Jaap Karssenberg (jaap.karssenberg)]

Will commit in rev632

[Jaap Karssenberg (jaap.karssenberg)]

Fix released in version 0.59