problems with quick notes

[Robin Lee]

Original report: https://bugzilla.redhat.com/show_bug.cgi?id=680057

Description of problem:
While trying to write a quick note and unselecting "Create a new page for each
note", it triggers the following error:

Version-Release number of selected component (if applicable):
Zim-0.50-1.fc14.noarch

How reproducible:
Open up Zim; create a quick note and unselect "Create a new page for each note"

Steps to Reproduce:
1. Open Zim
2. Go to File > Quick Note
3. Enter some text and a page name, and deactivate "Create a new page for each note"
4. Click OK

Actual results:

This is zim 0.50
Python version is sys.version_info(major=2, minor=7, micro=0,
releaselevel='final', serial=0)
Gtk version is (2, 22, 0)
Pygtk version is (2, 17, 0)
Platform is posix
Zim revision is:
  branch: pyzim-trunk
  revision: 350 <email address hidden>
  date: 2011-02-14 22:38:51 +0100

======= Traceback =======
  File "/usr/lib/python2.7/site-packages/zim/gui/widgets.py", line 1838, in
do_response
    destroy = self.do_response_ok()
  File "/usr/lib/python2.7/site-packages/zim/plugins/quicknote.py", line 293,
in do_response_ok
    ui.present(page) # also works with proxy
NameError: global name 'page' is not defined

Expected results:
No errors

[Renich (renich-redhat-bugs)]

Description of problem:
While trying to write a quick note and unselecting "Create a new page for each note", it triggers the following error:

Version-Release number of selected component (if applicable):
Zim-0.50-1.fc14.noarch

How reproducible:
Open up Zim; create a quick note and unselect "Create a new page for each note"

Steps to Reproduce:
1. Open Zim
2. Go to File > Quick Note
3. Enter some text and deactivate "Create a new page for each note"
4. Click OK

Actual results:

This is zim 0.50
Python version is sys.version_info(major=2, minor=7, micro=0, releaselevel='final', serial=0)
Gtk version is (2, 22, 0)
Pygtk version is (2, 17, 0)
Platform is posix
Zim revision is:
  branch: pyzim-trunk
  revision: 350 <email address hidden>
  date: 2011-02-14 22:38:51 +0100

======= Traceback =======
  File "/usr/lib/python2.7/site-packages/zim/gui/widgets.py", line 1838, in do_response
    destroy = self.do_response_ok()
  File "/usr/lib/python2.7/site-packages/zim/plugins/quicknote.py", line 293, in do_response_ok
    ui.present(page) # also works with proxy
NameError: global name 'page' is not defined

Expected results:
No errors

[Robin Lee (cheeselee)]

And if I click OK before entering a page name, the dialog should alert me instead of keeping silent. Or the OK button should be disabled before required information was entered.

[Jaap Karssenberg (jaap.karssenberg)]

Will commit fix in rev359

[Fedora (fedora-redhat-bugs)]

Zim-0.50-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/Zim-0.50-2.fc15

[Fedora (fedora-redhat-bugs)]

Zim-0.50-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/Zim-0.50-2.fc14

[Fedora (fedora-redhat-bugs)]

Zim-0.50-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with
 su -c 'yum --enablerepo=updates-testing update Zim'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/Zim-0.50-2.fc14

[Fedora (fedora-redhat-bugs)]

Zim-0.50-2.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.

[Fedora (fedora-redhat-bugs)]

Zim-0.50-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.

[Jaap Karssenberg (jaap.karssenberg)]

Released in zim 0.51