missing company information in payment.order and payment.line

Bug #724059 reported by Albert Cervera i Areny - http://www.NaN-tic.com
26
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 3

Bug Description

payment.order and payment.line models in account_payment module do not have the necessary company_id fields and rules.

payment.mode *does* have that field and its rule.

Tags: nan

Related branches

description: updated
description: updated
Amit Parik (amit-parik)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: New → Confirmed
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Rifakat Husen (OpenERP) (rha-openerp) wrote :

Hello,

It has been fixed in lp:~openerp-dev/openobject-addons/trunk-bug-724059-rha,
Revision ID: <email address hidden>
Revision no: 4447

Thanks for reporting,
rha

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Àngel Àlvarez http://www.nan-tic.com (angel-nan) wrote :

Thank you Rifakat, but I've seen you made the company_id field in payment.line a many2one. IMHO it should be of type related, so if the user changes the company of payment.order it is changed in lines too. This is the way it's implemented in invoices/invoice lines or purchase orders, for example.

Changed in openobject-addons:
status: Fix Committed → New
Changed in openobject-addons:
status: New → Confirmed
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Angel,

Yes you are right it should be related field on pay order line. And i think company id field on payment order should be related with payment mode's company.
I need your suggestion.

Thank you,
mra

Revision history for this message
Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan) wrote :

Hi Mustafa,
I agree this could be related.

+1 for making them related.

Changed in openobject-addons:
milestone: none → 6.1
Revision history for this message
Rifakat Husen (OpenERP) (rha-openerp) wrote :

Hello Àngel,

I have fixed it in lp:~openerp-dev/openobject-addons/trunk-bug-724059-rha ,
Revision ID: <email address hidden>
Revision no: 4449

Regards,
rha

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Ferdinand (office-chricar) wrote :

IMHO this must go into 6.0.2
Payment is unusable without this in multicompany envirenment

may be you can provide a patch here against 6.0.x

Revision history for this message
qdp (OpenERP) (qdp) wrote :

merge rejected. Same player, try again

Changed in openobject-addons:
status: Fix Committed → Confirmed
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Rifakat Husen (OpenERP) (rha-openerp) wrote :

Hello,

I did changes for record rules in lp:~openerp-dev/openobject-addons/trunk-bug-724059-rha ,
Revision ID: <email address hidden>
Revision no: 4450

Thanks.

Changed in openobject-addons:
status: In Progress → Fix Committed
qdp (OpenERP) (qdp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.