Remove the local image service (nova/image/local.py)

Bug #723947 reported by Dan Prince
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
Unassigned

Bug Description

The local image service seems stale and should probably be removed.

Glance now supports a local image store which could be used to achieve similar functionality in a more standardized manner.

Related branches

Revision history for this message
Christian Berendt (berendt) wrote :

You're talking about nova-objectstore, right?

I don't think it's a good idea to remove it at the moment.

- it's working for me and i'm using it in my development landscape at the moment and i don't want to manually add nova-objectstore through a patch
- there are several issues while using euca2ools with glance (for example https://bugs.launchpad.net/glance/+bug/723966)
- it's a nice to have for development (i don't have to waste time with errors in glance)

Revision history for this message
Thierry Carrez (ttx) wrote :

The EC2 API requires an S3 implementation to upload images to. nova-objectstore provides a simple way of doing this. Otherwise in order to use the EC2 API you would have to upload to the real S3, or deploy Swift with the S3 front-end.

Until Glance provides some S3 frontend that could be used in the EC2 API, I don't think we can spare nova-objectstore.

See discussion at: https://lists.launchpad.net/openstack/msg00296.html

Changed in nova:
status: New → Incomplete
Revision history for this message
Dan Prince (dan-prince) wrote :

Sorry for the confusion.

I'm actually just talking about removing nova/image/local.py. I understood that to be the 'Local Image Service'.

Both S3 and the object-store would remain.

The nova/image/local.py looks to me to be unusable. It actually creates a temp directory in the code in which to store the images. It was my understanding this was a pre-Glance class and now the the OS API supports Glance (which has a local image storage mode) it could be deleted.

summary: - Remove the local image service
+ Remove the local image service (nova/images/local.py)
summary: - Remove the local image service (nova/images/local.py)
+ Remove the local image service (nova/image/local.py)
Revision history for this message
Thierry Carrez (ttx) wrote :

@Dan: its generally good to raise code deletion questions in a ML thread to bring that to people's attention. Not everyone reads every bug :)

Revision history for this message
Dan Prince (dan-prince) wrote :

My issue with nova/images/local.py was that is created a new temp directory in init (which seemed pointless for anything except unit testing).

Looks like it is being refactored in lp:~vishvananda/nova/kill-objectstore so that it is used by S3. So we should keep it.

Dan Prince (dan-prince)
Changed in nova:
status: Incomplete → Invalid
Revision history for this message
Jay Pipes (jaypipes) wrote :

This is still valid. We should remove the local image service entirely.

Changed in nova:
status: Invalid → Triaged
Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Wishlist
Thierry Carrez (ttx)
Changed in nova:
status: Triaged → In Progress
Thierry Carrez (ttx)
Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → diablo-2
Thierry Carrez (ttx)
Changed in nova:
milestone: diablo-2 → 2011.3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.