pcb

pcb manual regexp appendix

Bug #723931 reported by KaiMartin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pcb
Fix Released
Undecided
Unassigned

Bug Description

The regexp appendix in the pcb manual omits the "|" and the "$" character. Both are useful for searches in the layout. The attached patch adds these and gives examples on usage. In addition, it reformats the table of examples to yield a more pleasant read.

---<)kaimartin(>---

Tags: docs
Revision history for this message
KaiMartin (kmk-familieknaak) wrote :
description: updated
description: updated
tags: added: docs
Revision history for this message
Felix Ruoff (felixruoff) wrote :

Hi Kaimartin!

Your patch applies fine at my system. Page layout looks nicer than before, thanks.

Two suggestions for further improvements:
- i think, in line 60 you did a typing error. Do you mean 'Precede'?
- Some of the sentences in the table are ended with fullstop, others are not. I would like to have it consistently.

Revision history for this message
KaiMartin (kmk-familieknaak) wrote :

Hi Felix!
Thanks for the review.
The patch below comes without the typo and added full stops to all the items in the list. "git amend" was my friend :-)

---<)kaimartin(>---

Revision history for this message
KaiMartin (kmk-familieknaak) wrote :

Corrected more typos.

Revision history for this message
Ineiev (ineiev) wrote :

Could you elaborate on the braces, brackets and parentheses? also, I think "Alternation" more fits the meaning
of "|" than "Concatenation".

Revision history for this message
KaiMartin (kmk-familieknaak) wrote :

As suggested by Ineiev, this version of the patch also adds a description of brackets. The vertical bar is called alteration operator. There is a note that regular expressions in pcb are not case sensitive.

Revision history for this message
Ineiev (ineiev) wrote :

Thank you!

Pushed, with minor amendments.

Changed in pcb:
status: New → Fix Committed
Revision history for this message
KaiMartin (kmk-familieknaak) wrote :

Thanks!

---<)kaimartin(>---

Peter Clifton (pcjc2)
Changed in pcb:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.