BranchSet:CollectionResource#branches timeouts
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Robert Collins |
Bug Description
205 SELECT Person.account, Person.
GET: 203 Other: 2 Robots: 115 Local: 18
17 https:/
OOPS-1878O1181, OOPS-1878O1431, OOPS-1878O1654, OOPS-1878O2010, OOPS-1878O2026
Branch: launchpad-rev-12406
Revno: 12406
SQL time: 11955 ms
Non-sql time: 2488 ms
Total time: 14443 ms
Statement Count: 267
One long query which is tolerable:
1 1395.0 1 SQL-launchpad-
SELECT Branch.
Branch.id,
Branch.name,
FROM Branch
WHERE Branch.private = FALSE
AND Branch.last_scanned IS NOT NULL
AND Branch.private = FALSE
ORDER BY Branch.
OFFSET $INT
many seconds in repeated querys:
Repeated SQL Statements top
Reps Total time Average time Saving Database id Statement
1 62 1657 26 1631 SQL-launchpad-
SELECT SeriesSourcePac
FROM SeriesSourcePac
WHERE SeriesSourcePac
ORDER BY SeriesSourcePac
2 62 1541 24 1517 SQL-launchpad-
SELECT ProductSeries.
FROM ProductSeries
WHERE ProductSeries.
3 53 2765 52 2713 SQL-launchpad-
SELECT Person.account,
Person.icon,
Person.id,
Person.logo,
Person.name,
FROM Person
WHERE Person.id = $INTLIMIT $INT
4 34 1568 46 1522 SQL-launchpad-
SELECT CodeImport.
FROM CodeImport
WHERE CodeImport.branch = $INT
ORDER BY CodeImport.id
5 28 2196 78 2118 SQL-launchpad-
SELECT Product.
FROM Product
WHERE Product.id = $INTLIMIT $INT
lazy evaluation of:
products
codeimports
productseries
sourcepackages
persons
Related branches
- Robert Collins (community): Approve
- Stuart Bishop (community): Needs Information
-
Diff: 606 lines (+159/-55)20 files modifiedlib/lp/app/doc/tales.txt (+2/-0)
lib/lp/app/widgets/suggestion.py (+3/-1)
lib/lp/code/browser/branchlisting.py (+3/-3)
lib/lp/code/feed/branch.py (+1/-1)
lib/lp/code/interfaces/branch.py (+11/-3)
lib/lp/code/interfaces/branchcollection.py (+4/-1)
lib/lp/code/interfaces/branchnamespace.py (+5/-2)
lib/lp/code/interfaces/hasbranches.py (+3/-1)
lib/lp/code/interfaces/seriessourcepackagebranch.py (+7/-0)
lib/lp/code/model/branch.py (+29/-13)
lib/lp/code/model/branchcollection.py (+49/-9)
lib/lp/code/model/branchnamespace.py (+1/-1)
lib/lp/code/model/hasbranches.py (+2/-2)
lib/lp/code/model/seriessourcepackagebranch.py (+6/-1)
lib/lp/code/model/tests/test_branchset.py (+26/-12)
lib/lp/code/model/tests/test_branchtarget.py (+1/-1)
lib/lp/code/tests/test_helpers.py (+2/-1)
lib/lp/code/vocabularies/branch.py (+1/-1)
lib/lp/codehosting/branchdistro.py (+2/-1)
lib/lp/codehosting/scanner/mergedetection.py (+1/-1)
description: | updated |
tags: | added: bad-commit-12505 |
tags: |
added: qa-bad removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
status: | Fix Released → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
One cause looks like late evaluation of sourcepackage. linked_ branches