Api traceback when using novatools list

[Antony Messerli]

I get this using novatools list or various other commands through novatools, running rev 706 of trunk.

2011-02-20 10:31:26,277 ERROR nova.api.openstack [-] Caught error: 'NoneType' object is unsubscriptable
(nova.api.openstack): TRACE: Traceback (most recent call last):
(nova.api.openstack): TRACE: File "/root/openstack/nova/nova/api/openstack/__init__.py", line 53, in __call__
(nova.api.openstack): TRACE: return req.get_response(self.application)
(nova.api.openstack): TRACE: File "/usr/lib/pymodules/python2.6/webob/request.py", line 919, in get_response
(nova.api.openstack): TRACE: application, catch_exc_info=False)
(nova.api.openstack): TRACE: File "/usr/lib/pymodules/python2.6/webob/request.py", line 887, in call_application
(nova.api.openstack): TRACE: app_iter = application(self.environ, start_response)
(nova.api.openstack): TRACE: File "/usr/lib/pymodules/python2.6/webob/dec.py", line 159, in __call__
(nova.api.openstack): TRACE: return resp(environ, start_response)
(nova.api.openstack): TRACE: File "/usr/lib/pymodules/python2.6/webob/dec.py", line 159, in __call__
(nova.api.openstack): TRACE: return resp(environ, start_response)
(nova.api.openstack): TRACE: File "/usr/lib/pymodules/python2.6/webob/dec.py", line 159, in __call__
(nova.api.openstack): TRACE: return resp(environ, start_response)
(nova.api.openstack): TRACE: File "/usr/lib/pymodules/python2.6/routes/middleware.py", line 131, in __call__
(nova.api.openstack): TRACE: response = self.app(environ, start_response)
(nova.api.openstack): TRACE: File "/usr/lib/pymodules/python2.6/webob/dec.py", line 159, in __call__
(nova.api.openstack): TRACE: return resp(environ, start_response)
(nova.api.openstack): TRACE: File "/usr/lib/pymodules/python2.6/webob/dec.py", line 147, in __call__
(nova.api.openstack): TRACE: resp = self.call_func(req, *args, **self.kwargs)
(nova.api.openstack): TRACE: File "/usr/lib/pymodules/python2.6/webob/dec.py", line 208, in call_func
(nova.api.openstack): TRACE: return self.func(req, *args, **kwargs)
(nova.api.openstack): TRACE: File "/root/openstack/nova/nova/wsgi.py", line 323, in __call__
(nova.api.openstack): TRACE: result = method(**arg_dict)
(nova.api.openstack): TRACE: File "/root/openstack/nova/nova/api/openstack/servers.py", line 113, in detail
(nova.api.openstack): TRACE: return self._items(req, entity_maker=_translate_detail_keys)
(nova.api.openstack): TRACE: File "/root/openstack/nova/nova/api/openstack/servers.py", line 122, in _items
(nova.api.openstack): TRACE: res = [entity_maker(inst)['server'] for inst in limited_list]
(nova.api.openstack): TRACE: File "/root/openstack/nova/nova/api/openstack/servers.py", line 68, in _translate_detail_keys
(nova.api.openstack): TRACE: private_ip = inst['fixed_ip']['address']
(nova.api.openstack): TRACE: TypeError: 'NoneType' object is unsubscriptable
(nova.api.openstack): TRACE:

[Antony Messerli (antonym)]

Appears to be related to code introduced in rev 692 (Update the Openstack API so that it returns 'addresses'.)

[Dan Prince (dan-prince)]

The attached patch should resolve this issue.

[Antony Messerli (antonym)]

Tested it out and it appears to have resolved the error.

[Dan Prince (dan-prince)]

A fix for this has long since been commited. The solution was to use utils.get_from_path which doesn't throw an exception if the key at the specified path is missing.

Should be good to go. Marking as fixed.