revno 5648 on bzr.dev broke loom tests

[Vincent Ladeuil]

ERROR: bzrlib.plugins.loom.tests.test_branch.TestLoom.test_sprout_nonempty_loom_bottom
ERROR: bzrlib.tests.per_branch.test_pull.TestPull.test_pull_merges_and_fetches_tags(BzrBranchLoomFormat6)
ERROR: bzrlib.tests.per_branch.test_pull.TestPull.test_pull_merges_and_fetches_tags(BzrBranchLoomFormat7)
ERROR: bzrlib.tests.per_branch.test_pull.TestPull.test_pull_stop_revision_merges_and_fetches_tags(BzrBranchLoomFormat7)
ERROR: bzrlib.tests.per_branch.test_pull.TestPull.test_pull_stop_revision_merges_and_fetches_tags(BzrBranchLoomFormat6)
ERROR: bzrlib.tests.per_branch.test_sprout.TestSprout.test_sprout_preserves_tags(BzrBranchLoomFormat7)
ERROR: bzrlib.tests.per_branch.test_sprout.TestSprout.test_sprout_preserves_tags(BzrBranchLoomFormat6)
ERROR: bzrlib.plugins.loom.tests.test_branch.TestLoom.test_clone_nonempty_loom_bottom
ERROR: bzrlib.plugins.loom.tests.test_branch.TestLoom.test_sprout_remote_loom
ERROR: bzrlib.plugins.loom.tests.test_branch.TestLoom.test_sprout_nonempty_loom_bottom

[Vincent Ladeuil (vila)]

I didn't run the tests in a loom since it landed, sorry for the delay.

Marking as critical as this is a regression.

I tried to look into it, but nothing obvious there :-/

[Andrew Bennetts (spiv)]

Most of those tests are new in that revision; bzr-loom's branch implementation needs to be updated to match the new behaviour (i.e. fetch tagged revisions during pull and sprout). So in terms of end user functionality there's no regression there.

The bzrlib.plugins.loom tests that are failing are more of a concern, but probably a shallow issue of needing to be updated for the API changes documented in that revision:

* ``Branch.fetch`` implementations must now accept an optional
+ ``fetch_spec`` keyword argument. (Andrew Bennetts)
+
+* ``Branch.import_last_revision_info`` is deprecated. Use the
+ ``import_last_revision_info_and_tags`` method instead.
+ (Andrew Bennetts)
+
+* The ``revision_id`` parameter of
+ ``Repository.search_missing_revision_ids`` and
+ ``InterRepository.search_missing_revision_ids`` is deprecated. It is
+ replaced by the ``revision_ids`` parameter. (Andrew Bennetts)

[Andrew Bennetts (spiv)]

Seeing as I'm familiar with the necessary changes already I'll take care of this. It should be pretty easy.

[Andrew Bennetts (spiv)]

Fixed in trunk r131.