PPL

Photo sync should check if the size of a photo exists

Bug #721060 reported by Christopher Adams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PPL
Fix Released
Critical
Christopher Adams

Bug Description

Photo sync will output an error if the JSON response from Flickr does not contain the expected sizes. E.g.:

Notice: Undefined index: url_m in /home/aikilab/public_html/pple/assets/extensions/ppl_flickr.php on line 269

Changed in ppl:
status: New → Confirmed
importance: Undecided → Critical
milestone: none → 0.3
assignee: nobody → Christopher Adams (christopheradams)
Revision history for this message
Christopher Adams (christopheradams) wrote :

Which sizes need to be checked for?

PPL attempts to import square, thumbnail, small and medium.

Is every photo on Flickr guaranteed to have at least a square and thumbnail size?

Revision history for this message
Christopher Adams (christopheradams) wrote :

Also saw the error:

Notice: Undefined index: url_s in /home/aikilab/public_html/pple/assets/extensions/ppl_flickr.php on line 267

Revision history for this message
Christopher Adams (christopheradams) wrote :

Adding checking for small and mediums sizes:

if (isset($photo['url_s']) and $photo['url_s']){
  $small_url = $photo['url_s'];
}

if (isset($photo['url_m']) and $photo['url_m']){
  $medium_url = $photo['url_m'];
}

Changed in ppl:
status: Confirmed → In Progress
Changed in ppl:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.