Doesn't seem to work with GMail notifications

Bug #720246 reported by Neil J. Patel
80
This bug affects 17 people
Affects Status Importance Assigned to Milestone
Chromify-OSD
Status tracked in Extension
Extension
Fix Released
Medium
Marco Ceppi

Bug Description

Not sure if it's because of the html notification thing, but it still shows up as one of the ugly notifications when someone emails or chats in gmail.

Related branches

Jorge Castro (jorge)
Changed in chromify-osd:
status: New → Confirmed
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Google has an interesting way of handling their notifications in that they do a "regression" check. If the browser supports webkitNotifications it will first try to do an HTML notification - then fall back to a regular notification. Getting HTML notifications to work - perfectly - is current focus of development.

Changed in chromify-osd:
importance: Undecided → Wishlist
assignee: nobody → Marco Ceppi (marco-ceppi)
Marco Ceppi (marcoceppi)
Changed in chromify-osd:
milestone: none → 2.2
Revision history for this message
Yuriy Voziy (yuretsz) wrote :

Doesn't work with campfire notification plugin either.
https://chrome.google.com/webstore/detail/dhjofeagfmjfndjfnfhehfpghejghecb

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Yuriy since that is a completely different extension could you please make a new bug report for that.

Revision history for this message
Rod Davis (ahylianhuman) wrote :

I've also noticed that since I've installed this plugin the default notifications do not dismiss, even when clicked on. The x button does not respond at all.

Revision history for this message
Jack Deslippe (jdeslip) wrote :

It also doesn't work with TweetDeck notifications - I assume this also related html5?

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Yes. TweetDeck is the prime example of *why* HTML5 Notifications will never be a good idea with Chromify-OSD - The popups offer additional action buttons to be leveraged (Like reply, profile, DM, etc) Since only text can be passed to Notify-OSD it makes it really hard to argue for a regression in technology like this. Next release will include experimental HTML5 support that will be disabled by default and enable-able in the settings pane.

Revision history for this message
Drew Wilson (atwilson) wrote :

Just a note - Gmail notifications do not use HTML, they are plain text + icon notifications.

I'm happy to help diagnose any problems you have getting this to work with gmail notifications - looking at your source code, it should work fine except: Gmail uses notification.close() to shut down notifications automatically (so it automatically closes chat notifications when you bring the Gmail window to the foreground and also auto-closes mail notifications so it can display the next notification in the queue). It doesn't look like you hook this currently which is going to break the Gmail notification FSM. Gmail also expects to be notified via an onclose() handler when a notification closes automatically.

Revision history for this message
Drew Wilson (atwilson) wrote :

BTW, looks like you have this in your manifest.json:

"matches": [ "http://*/*" ],

This won't match https, which might explain why this doesn't work for gmail - your content script isn't injected for https pages. Apparently, you can try:

"matches": [ "<all_urls>" ],

and that will do what you want.

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Drew, Thanks for your research - I had spent some time looking through the compressed JS for gMail and (at the time) had come to the conclusion that gMail first tries HTML, then regresses to standard, until finally stopping. I'll try out this change to the manifest and see what happens.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.