Nova returns non-compliant tag for DescribeKeypairs

[Masanori Itoh]

I'm trying to work with nova using tAWS (http://sourceforge.jp/projects/eclipse-aws/), an eclipse based tool for Amazon EC2 compatible cloud services.

I noticed that nova returns a non-compliant tag <keypairsSet> instead of <keySet> which is defined in the Amazon EC2 API spec for DescribeKeypairs request.
Python boto does not matter the difference, but we get errors for some Amazon AWS access libraries (e.g., a Java library which tAWS uses) which do more strict message checking than boto does.

The attached patch fixes the issue.
I checked the patch nova rev 645, but the issue remains in rev 681 too.

Signed-off-by: Masanori Itoh <email address hidden>

=== modified file 'nova/api/ec2/cloud.py'
--- nova/api/ec2/cloud.py 2011-02-15 00:51:51 +0000
+++ nova/api/ec2/cloud.py 2011-02-16 15:10:37 +0000
@@ -297,7 +297,7 @@
                     'keyFingerprint': key_pair['fingerprint'],
                 })

- return {'keypairsSet': result}
+ return {'keySet': result}

     def create_key_pair(self, context, key_name, **kwargs):
         LOG.audit(_("Create key pair %s"), key_name, context=context)

[Masanori Itoh (itohm)]

Hi,

I pushed my bugfix branch as lp:~itoumsn/nova/lp720133, and I've liked it to this bug report.

What should I do next?

[Thierry Carrez (ttx)]

You should propose this branch for merging into lp:nova.