hotplug: Loads framebuffer without questioning, breaking working system

Bug #7200 reported by Debian Bug Importer
4
Affects Status Importance Assigned to Milestone
hotplug (Debian)
Fix Released
Unknown
hotplug (Ubuntu)
Invalid
High
Unassigned

Bug Description

Automatically imported from Debian bug report #261958 http://bugs.debian.org/261958

Revision history for this message
In , Fumitoshi UKAI (ukai) wrote : Re: Bug#261958: hotplug: Loads framebuffer without questioning, breaking working system
Download full text (3.8 KiB)

retitle 261958 hotplug: Loads framebuffer without questioning, breaking working system on 2.4 kernel
thanks

This is because pciutils adds pcimodules on 1:2.1.11-13, so hotplug
works pci coldplugging correctly on 2.4 kernel. Unfortunately, some
devices, especially framebuffer devices, won't work fine.
For 2.6 kernel, hotplug/ignore_pci_class_display would be used to
control whether display class pci devices will be handled in hotplug
or not, but for 2.4 kernel, all of pci modules will be handled now.

I'm thinking that I'll add the code in hotplug.functions:load_drivers()
when hotplug/ignore_pci_class_display is true, check module path includes
"drivers/video".

Does this patch fix your problem?

--- hotplug.functions.orig 2004-07-29 17:21:16.000000000 +0900
+++ hotplug.functions 2004-07-29 17:24:00.000000000 +0900
@@ -160,6 +160,14 @@
   continue
      fi

+ # XXX: check PCI video modules
+ # It may break working systems. Bug#261958
+ if [ "$IGNORE_PCI_CLASS_DISPLAY" = "true" ] && $MODPROBE -n -v "$MODULE" | grep -q '/drivers/video/' > /dev/null 2>&1; then
+
+ mesg " $MODULE: ignore display modules"
+ continue
+ fi
+
      # statically linked modules aren't shown by 'lsmod',
      # and user mode drivers will ONLY have a setup script;
      # it's not an error if a module doesn't exist or won't load.

Regards,
Fumitoshi UKAI

At Thu, 29 Jul 2004 09:32:30 +0200,
Helge Kreutzmann wrote:

> After upgrading pciutils from 11-11 to 11-15 hotplug loads the
> framebuffer modules and initializes framebuffer. Since nothing is
> prepared for it, the first console has a broken font (but this
> is also on my ibook), X barly works
> (but no keyboard), and leaving X gives me a almost black "console",
> ie. input only.(2)
>
> I never used framebuffer on this machine and I currently do not intend
> to. And I definitly never consented to loading the appropriate
> modules(1) (although they are build, because at some stage I wanted to
> experiment but did not have time).
>
> All other hotplug systems are harmless, since the modules can be
> unloaded and everything is fine again, this is not the case for
> framebuffer. Also since when is a video device "hotpluggable"?
>
> If this bug is related to pciutils or discover, please reassign. If
> you need more information, please tell me which.
>
> (1) Looking at the debconf-info below this is confirmed (If I
> understand them correctly). And I do not have a USB keyboard.
>
> (2) Yes, these are bugs which should be reported separately and
> independent of hotplug. But hotplug should not change the working
> of a system in such a fundamental way as to open a can of new
> bugs in other software, especially since the users might need the
> machine in the mean time.
>
> -- System Information:
> Debian Release: testing/unstable
> APT prefers testing
> APT policy: (990, 'testing')
> Architecture: alpha
> Kernel: Linux 2.4.26
> Locale: LANG=de_DE@euro, LC_CTYPE=de_DE@euro
>
> Versions of packages hotplug depends on:
> ii debconf 1.4.29 Debian configuration management sy
> ii modutils 2.4.26-1 Linux module utilities
> ...

Read more...

Revision history for this message
In , Marco d'Itri (md) wrote :

This was changed in a newer version of hotplug.

--
ciao, |
Marco | [7333 lawc7txCLa1Og]

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Automatically imported from Debian bug report #261958 http://bugs.debian.org/261958

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Thu, 29 Jul 2004 09:32:30 +0200
From: Helge Kreutzmann <email address hidden>
To: <email address hidden>
Subject: hotplug: Loads framebuffer without questioning, breaking working system

--a8Wt8u1KmwUX3Y2C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: hotplug
Version: 0.0.20040329-11
Severity: critical
Justification: breaks unrelated software

After upgrading pciutils from 11-11 to 11-15 hotplug loads the
framebuffer modules and initializes framebuffer. Since nothing is
prepared for it, the first console has a broken font (but this=20
is also on my ibook), X barly works=20
(but no keyboard), and leaving X gives me a almost black "console",
ie. input only.(2)

I never used framebuffer on this machine and I currently do not intend
to. And I definitly never consented to loading the appropriate
modules(1) (although they are build, because at some stage I wanted to
experiment but did not have time).

All other hotplug systems are harmless, since the modules can be
unloaded and everything is fine again, this is not the case for
framebuffer. Also since when is a video device "hotpluggable"?

If this bug is related to pciutils or discover, please reassign. If
you need more information, please tell me which.

(1) Looking at the debconf-info below this is confirmed (If I
    understand them correctly). And I do not have a USB keyboard.

(2) Yes, these are bugs which should be reported separately and
    independent of hotplug. But hotplug should not change the working
    of a system in such a fundamental way as to open a can of new
    bugs in other software, especially since the users might need the
    machine in the mean time.

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: alpha
Kernel: Linux 2.4.26
Locale: LANG=3Dde_DE@euro, LC_CTYPE=3Dde_DE@euro

Versions of packages hotplug depends on:
ii debconf 1.4.29 Debian configuration managemen=
t sy
ii modutils 2.4.26-1 Linux module utilities
ii procps 1:3.2.1-2 The /proc file system utilities

-- debconf information:
  hotplug/ignore_pci_class_display: true
  hotplug/net_agent_policy: hotplug
  hotplug/static_module_list:
  hotplug/usbd_enable: true
* hotplug/usb_keyboard:
  hotplug/x11_usbmice_hack: false
--=20
Helge Kreutzmann, Dipl.-Phys. <email address hidden>=
er.de
  gpg signed mail preferred gpg-key: finger <email address hidden>=
er.de
    64bit GNU powered http://www.itp.uni-hannover.de/~kreu=
tzm
       Help keep free software "libre": http://www.freepatents.org/

--a8Wt8u1KmwUX3Y2C
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBCKgNRsxcY/MYpWoRAvQqAKCApOHpL314ArEsE81fUmIujB2+eQCgpU1p
qsh+A0ZcsZRuyG5wrcF+xLk=
=tAep
-----END PGP SIGNATURE-----

--a8Wt8u1KmwUX3Y2C--

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (4.1 KiB)

Message-ID: <email address hidden>
Date: Thu, 29 Jul 2004 17:25:55 +0900
From: Fumitoshi UKAI <email address hidden>
To: Helge Kreutzmann <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#261958: hotplug: Loads framebuffer without questioning, breaking working system

retitle 261958 hotplug: Loads framebuffer without questioning, breaking working system on 2.4 kernel
thanks

This is because pciutils adds pcimodules on 1:2.1.11-13, so hotplug
works pci coldplugging correctly on 2.4 kernel. Unfortunately, some
devices, especially framebuffer devices, won't work fine.
For 2.6 kernel, hotplug/ignore_pci_class_display would be used to
control whether display class pci devices will be handled in hotplug
or not, but for 2.4 kernel, all of pci modules will be handled now.

I'm thinking that I'll add the code in hotplug.functions:load_drivers()
when hotplug/ignore_pci_class_display is true, check module path includes
"drivers/video".

Does this patch fix your problem?

--- hotplug.functions.orig 2004-07-29 17:21:16.000000000 +0900
+++ hotplug.functions 2004-07-29 17:24:00.000000000 +0900
@@ -160,6 +160,14 @@
   continue
      fi

+ # XXX: check PCI video modules
+ # It may break working systems. Bug#261958
+ if [ "$IGNORE_PCI_CLASS_DISPLAY" = "true" ] && $MODPROBE -n -v "$MODULE" | grep -q '/drivers/video/' > /dev/null 2>&1; then
+
+ mesg " $MODULE: ignore display modules"
+ continue
+ fi
+
      # statically linked modules aren't shown by 'lsmod',
      # and user mode drivers will ONLY have a setup script;
      # it's not an error if a module doesn't exist or won't load.

Regards,
Fumitoshi UKAI

At Thu, 29 Jul 2004 09:32:30 +0200,
Helge Kreutzmann wrote:

> After upgrading pciutils from 11-11 to 11-15 hotplug loads the
> framebuffer modules and initializes framebuffer. Since nothing is
> prepared for it, the first console has a broken font (but this
> is also on my ibook), X barly works
> (but no keyboard), and leaving X gives me a almost black "console",
> ie. input only.(2)
>
> I never used framebuffer on this machine and I currently do not intend
> to. And I definitly never consented to loading the appropriate
> modules(1) (although they are build, because at some stage I wanted to
> experiment but did not have time).
>
> All other hotplug systems are harmless, since the modules can be
> unloaded and everything is fine again, this is not the case for
> framebuffer. Also since when is a video device "hotpluggable"?
>
> If this bug is related to pciutils or discover, please reassign. If
> you need more information, please tell me which.
>
> (1) Looking at the debconf-info below this is confirmed (If I
> understand them correctly). And I do not have a USB keyboard.
>
> (2) Yes, these are bugs which should be reported separately and
> independent of hotplug. But hotplug should not change the working
> of a system in such a fundamental way as to open a can of new
> bugs in other software, especially since the users might need the
> machine in the mean time.
>
> -- System Information:
> Debian Release: testing/unstable
> APT prefers testing
> APT policy: (990, 'testing')...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Thu, 29 Jul 2004 10:23:27 +0200
From: Marco d'Itri <email address hidden>
To: Helge Kreutzmann <email address hidden>,
 <email address hidden>
Subject: Re: Bug#261958: hotplug: Loads framebuffer without questioning, breaking working system

--xHFwDpU9dbj6ez1V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

This was changed in a newer version of hotplug.

--=20
ciao, |
Marco | [7333 lawc7txCLa1Og]

--xHFwDpU9dbj6ez1V
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBCLP/FGfw2OHuP7ERAueaAJ9TBLCjW3M8xdSLXEcGLfox41s7AQCfR+Bs
Rum+TCVly+Gz+jwdZ5hc+jk=
=sOiL
-----END PGP SIGNATURE-----

--xHFwDpU9dbj6ez1V--

Revision history for this message
In , Helge Kreutzmann (kreutzm) wrote :

Hello,
On Thu, Jul 29, 2004 at 05:25:55PM +0900, Fumitoshi UKAI wrote:

> I'm thinking that I'll add the code in hotplug.functions:load_drivers()
> when hotplug/ignore_pci_class_display is true, check module path includes
> "drivers/video".
>
> Does this patch fix your problem?

Yes. As I understand, this is already part of the next release?

Thanks

      Helge
--
Helge Kreutzmann, Dipl.-Phys. <email address hidden>
  gpg signed mail preferred gpg-key: finger <email address hidden>
    64bit GNU powered http://www.itp.uni-hannover.de/~kreutzm
       Help keep free software "libre": http://www.freepatents.org/

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Fri, 30 Jul 2004 08:47:09 +0200
From: Helge Kreutzmann <email address hidden>
To: Fumitoshi UKAI <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#261958: hotplug: Loads framebuffer without questioning, breaking working system

--G4iJoqBmSsgzjUCe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,
On Thu, Jul 29, 2004 at 05:25:55PM +0900, Fumitoshi UKAI wrote:
=20
> I'm thinking that I'll add the code in hotplug.functions:load_drivers()=
=20
> when hotplug/ignore_pci_class_display is true, check module path includes
> "drivers/video".
>=20
> Does this patch fix your problem?

Yes. As I understand, this is already part of the next release?

Thanks

      Helge
--=20
Helge Kreutzmann, Dipl.-Phys. <email address hidden>=
er.de
  gpg signed mail preferred gpg-key: finger <email address hidden>=
er.de
    64bit GNU powered http://www.itp.uni-hannover.de/~kreu=
tzm
       Help keep free software "libre": http://www.freepatents.org/

--G4iJoqBmSsgzjUCe
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBCe7tRsxcY/MYpWoRAkJWAJ9ffZILMvI4tvcg9BiNYa51bOKacACdHaql
D+uMjttOKzblJ7zKdLHfQfc=
=rt9v
-----END PGP SIGNATURE-----

--G4iJoqBmSsgzjUCe--

Revision history for this message
Matt Zimmerman (mdz) wrote :

Warty doesn't have the new pciutils which introduces this problem

Revision history for this message
In , Fumitoshi UKAI (ukai) wrote : Bug#261958: fixed in hotplug 0.0.20040329-13

Source: hotplug
Source-Version: 0.0.20040329-13

We believe that the bug you reported is fixed in the latest version of
hotplug, which is due to be installed in the Debian FTP archive:

hotplug_0.0.20040329-13.diff.gz
  to pool/main/h/hotplug/hotplug_0.0.20040329-13.diff.gz
hotplug_0.0.20040329-13.dsc
  to pool/main/h/hotplug/hotplug_0.0.20040329-13.dsc
hotplug_0.0.20040329-13_all.deb
  to pool/main/h/hotplug/hotplug_0.0.20040329-13_all.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Fumitoshi UKAI <email address hidden> (supplier of updated hotplug package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 6 Aug 2004 02:03:20 +0900
Source: hotplug
Binary: hotplug
Architecture: source all
Version: 0.0.20040329-13
Distribution: unstable
Urgency: low
Maintainer: Fumitoshi UKAI <email address hidden>
Changed-By: Fumitoshi UKAI <email address hidden>
Description:
 hotplug - Linux Hotplug Scripts
Closes: 260287 260385 261790 261958 262598 263556
Changes:
 hotplug (0.0.20040329-13) unstable; urgency=low
 .
   * fix isapnp.rc
     closes: Bug#261790
   * debian/patches/052_module_name_for_blacklist
     fix handling '-' or '_' in module name for blacklisting
     closes: Bug#263556
   * debian/patches/053_load_drivers_ignore_video
     ignore modprobing modules in drivers/video if $IGNORE_PCI_CLASS_DISPLAY
     closes: Bug#261958
   * add cs.po
     closes: Bug#260385
   * update nl.po pt_BR.po
     closes: Bug#260287, Bug#262598
Files:
 2399b3d5c5ec12b98de390dad3710023 673 admin standard hotplug_0.0.20040329-13.dsc
 ae8393d7b06f2f000e5afccdac9edade 42011 admin standard hotplug_0.0.20040329-13.diff.gz
 3a65cdb24b6ba9179e661258511f4d9e 62052 admin standard hotplug_0.0.20040329-13_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBEnTu9D5yZjzIjAkRAsM3AJ0UcDBIUoMIl/zzlvkSS/6nAkgV9QCaAvkf
rkmj/lvdK6PGAsPeVV+ggCI=
=6sRD
-----END PGP SIGNATURE-----

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Thu, 05 Aug 2004 14:17:09 -0400
From: Fumitoshi UKAI <email address hidden>
To: <email address hidden>
Subject: Bug#261958: fixed in hotplug 0.0.20040329-13

Source: hotplug
Source-Version: 0.0.20040329-13

We believe that the bug you reported is fixed in the latest version of
hotplug, which is due to be installed in the Debian FTP archive:

hotplug_0.0.20040329-13.diff.gz
  to pool/main/h/hotplug/hotplug_0.0.20040329-13.diff.gz
hotplug_0.0.20040329-13.dsc
  to pool/main/h/hotplug/hotplug_0.0.20040329-13.dsc
hotplug_0.0.20040329-13_all.deb
  to pool/main/h/hotplug/hotplug_0.0.20040329-13_all.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Fumitoshi UKAI <email address hidden> (supplier of updated hotplug package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 6 Aug 2004 02:03:20 +0900
Source: hotplug
Binary: hotplug
Architecture: source all
Version: 0.0.20040329-13
Distribution: unstable
Urgency: low
Maintainer: Fumitoshi UKAI <email address hidden>
Changed-By: Fumitoshi UKAI <email address hidden>
Description:
 hotplug - Linux Hotplug Scripts
Closes: 260287 260385 261790 261958 262598 263556
Changes:
 hotplug (0.0.20040329-13) unstable; urgency=low
 .
   * fix isapnp.rc
     closes: Bug#261790
   * debian/patches/052_module_name_for_blacklist
     fix handling '-' or '_' in module name for blacklisting
     closes: Bug#263556
   * debian/patches/053_load_drivers_ignore_video
     ignore modprobing modules in drivers/video if $IGNORE_PCI_CLASS_DISPLAY
     closes: Bug#261958
   * add cs.po
     closes: Bug#260385
   * update nl.po pt_BR.po
     closes: Bug#260287, Bug#262598
Files:
 2399b3d5c5ec12b98de390dad3710023 673 admin standard hotplug_0.0.20040329-13.dsc
 ae8393d7b06f2f000e5afccdac9edade 42011 admin standard hotplug_0.0.20040329-13.diff.gz
 3a65cdb24b6ba9179e661258511f4d9e 62052 admin standard hotplug_0.0.20040329-13_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBEnTu9D5yZjzIjAkRAsM3AJ0UcDBIUoMIl/zzlvkSS/6nAkgV9QCaAvkf
rkmj/lvdK6PGAsPeVV+ggCI=
=6sRD
-----END PGP SIGNATURE-----

Changed in hotplug:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.