[google] gdefine doesn't like an empty resultset
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ibid |
Fix Released
|
Low
|
Stefano Rivera |
Bug Description
Query: gdefine understeem
ERROR:scripts.
Traceback (most recent call last):
File "scripts/
processor.
File "./ibid/
method(event, *args)
File "./ibid/
event.
TypeError: sequence item 0: expected string or Unicode, NoneType found
Response: I'm not feeling too well
"understeem"? WTF did that come from?
Looks like our scraper was being a bit simplistic. It was returning definition lists like:
[None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None]
Related branches
- Max Rabkin: Approve
- Jonathan Hitchcock: Approve
- marcog (community): Approve
-
Diff: 13 lines (+2/-1)1 file modifiedibid/plugins/google.py (+2/-1)
- Max Rabkin: Approve
- Jonathan Hitchcock: Approve
- marcog (community): Approve
-
Diff: 13 lines (+2/-1)1 file modifiedibid/plugins/google.py (+2/-1)
Changed in ibid: | |
milestone: | 0.1.2 → 0.1.1 |
assignee: | nobody → Stefano Rivera (stefanor) |
Changed in ibid: | |
status: | In Progress → Fix Committed |
Changed in ibid: | |
status: | Fix Committed → Fix Released |