Calling relation-set multiple times, clears previous values

[Kapil Thangavelu]

<SpamapS> Interesting.. one thing that was somewhat unexpected.. in one hook, I called 'relation-set' twice w/ different vars..
<SpamapS> like.. relation-set ip=X;relation-set port=Y
<SpamapS> this resulted in no ip
<SpamapS> which now, I understand...
<SpamapS> but at the time, it was somewhat confusing.
<kapil> hmm.. that sounds odd
<kapil> SpamapS, that should work
<kapil> all the changes made by a hook are buffered till the hook completes and then flushed atomically to zookeeper
* kapil checks
<kapil> SpamapS, that's definitely a bug

[Kapil Thangavelu (hazmat)]

31<kapil> bcsaller, i think i found the issuse .. so the hook api is calling set with a dictionary, which effectively replaces the dict, instead of calling through to set value, which merges with the existing state.
31<kapil> in terms of how the hook context is managing state
18<bcsaller> huh
31<kapil> the set with dictionary api was there to support full scale replacement of values, ie. to support things like deleting values as well
31<kapil> bcsaller, i'm not sure how you would distinguish on the hook api server though
31<kapil> whether a client called with multiple values on a single line. vs stdin value replacement
31<kapil> bcsaller, yeah.. the distinction is a bit too subtle, there should probably be a more explicit delete exposed via a magic value on the client side hook api
21<bcsaller>21 kapil: agreed