Themes: <file> and <otherfile> are the same file

[Raoul Snyman]

Reported via bugs-at-openlp.org

Version: 1.9.4

--- Please enter the report below this line. ---
Theme image had disappeared from theme directory. Tried to copy it back in and got htis error

--- Exception Traceback ---
Traceback (most recent call last):
File "C:\Documents and Settings\raoul\My Documents\My
Projects\openlp\trunk\build\pyi.win32\OpenLP\outPYZ1.pyz/openlp.core.ui.themeform", line 593, in accept
File "C:\Documents and Settings\raoul\My Documents\My
Projects\openlp\trunk\build\pyi.win32\OpenLP\outPYZ1.pyz/openlp.core.ui.thememanager", line 671, in saveTheme
File "C:\Documents and Settings\raoul\My Documents\My Projects\openlp\trunk\build\pyi.win32\OpenLP\outPYZ1.pyz/shutil", line 47,
in copyfile
Error: `C:/Documents and Settings/Home/Application Data/openlp/data/themes/UrbanFunk/UrbanFunk.png` and `C:\Documents and
Settings\Home\Application Data\openlp\data\themes\UrbanFunk\UrbanFunk.png` are the same file

--- System information ---
Platform: Windows-XP-5.1.2600-SP3

--- Library Versions ---
Python: 2.6.2
Qt4: 4.6.1
Phonon: 4.3.1
PyQt4: 4.7
SQLAlchemy: 0.6.5
BeautifulSoup: 3.1.0.1
lxml: 2.2.4
Chardet: 1.0.1
PyEnchant: 1.6.3
PySQLite: 1.0.1

[Jon Tibble (meths)]

See also:
http://support.openlp.org/issues/77
http://support.openlp.org/issues/59

[Andreas Preikschat (googol-deactivatedaccount)]

I was able to reproduce this.

[Andreas Preikschat (googol-deactivatedaccount)]

I do not think that Tim will have the time to fix this in the few hours left to do so. (Furthermore he is not around anyway.)

[Tim Bentley (trb143)]

The code has changed since this bug was reported and it seems that guards have been added to block this path if I have understood the bug correctly.
If it still happens can I have a recipe to trigger it.
I have double imported the same theme and that works fine.

[Andreas Preikschat (googol-deactivatedaccount)]

Set to invalid... See http://support.openlp.org/issues/59#note-4

[Andreas Preikschat (googol-deactivatedaccount)]

There has just been a new ticket created: http://support.openlp.org/issues/298

[Tim Bentley (trb143)]

Bug report is against 1.9.7 and the line numbers do not match up.
Tried to reproduce and still am unable to.

[Tomas Groth (tomasgroth)]

This is actually still a problem:
Traceback (most recent call last):
  File "/home/tgc/OpenLP/openlp/trunk-2.0/openlp/core/ui/themeform.py", line 653, in accept
    self.thememanager.saveTheme(self.theme, saveFrom, saveTo)
  File "/home/tgc/OpenLP/openlp/trunk-2.0/openlp/core/ui/thememanager.py", line 671, in saveTheme
    self._writeTheme(theme, image_from, image_to)
  File "/home/tgc/OpenLP/openlp/trunk-2.0/openlp/core/ui/thememanager.py", line 706, in _writeTheme
    unicode(image_to).encode(encoding))
  File "/usr/lib/python2.7/shutil.py", line 69, in copyfile
    raise Error("`%s` and `%s` are the same file" % (src, dst))
Error: `/home/tgc/.local//share/openlp/themes/Moss on tree/climbing-moss.jpeg` and `/home/tgc/.local/share/openlp/themes/Moss on tree/climbing-moss.jpeg` are the same file