Launchpad itself

Translations branch auto-approver not working

Bug #719247 reported by Jeroen T. Vermeulen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Jeroen T. Vermeulen
Launchpad itself 11.03

Bug Description

We're seeing uploads from bzr branches not being approved. For example, see this question: https://answers.launchpad.net/launchpad/+question/144781

The upload is dated 2011-02-08. I don't see any reason why the template might not have been approved, nor any rosettabranches oopses that might be related to it.

Related branches

lp:~jtv/launchpad/bug-719247
Curtis Hovey (community): Approve (code)
j.c.sackett (community): Approve (code*)
Diff: 597 lines (+232/-121)
4 files modified
lib/lp/translations/model/approver.py (+17/-3)
lib/lp/translations/tests/test_translationbranchapprover.py (+155/-89)
lib/lp/translations/utilities/template.py (+6/-7)
lib/lp/translations/utilities/tests/test_templatenames.py (+54/-22)
Данило Шеган (danilo)
tags: added: regression rosetta-imports
tags: added: code-integration
removed: rosetta-imports
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

It looks as if sbackup may be in the same boat: https://translations.launchpad.net/sbackup/0.10

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

sbackup's template upload is dated 2010-09-24.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

I wonder if this is related. Attempts to approve the sbackup template upload time out in newPOFile→updateStatistics. For instance, OOPS-1872C1062.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Filed the timeouts separately as bug 719271.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Excuse me: as bug 719267.

Jeroen T. Vermeulen (jtv)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Jeroen T. Vermeulen (jtv)
milestone: none → 11.03
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

The instances I looked at turned out to be cases where the template file was called messages.pot or po/messages.pot. The branch approver can't extract a meaningful name/domain from that and gives up.

We can fix it so that the name and domain fall back to the project name. If that produces a duplicate name, that's not a new problem because the approver already backs off when it hits a duplicate.

Jeroen T. Vermeulen (jtv)
tags: removed: regression
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12416 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12416>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

This needs Q/A on staging, and staging is currently broken. Since this branch isn't quite blocking rollouts yet, I'll hold out for staging to become available just a little bit longer.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Nope, staging bzr is also broken and no admins are available. Sorry.

tags: added: qa-untestable
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.