Hr_payroll_account : Payslip approval crashes without notification if Property accounts are not configured!

[Kaveri Das]

In Human Resources when i am generating payslips, it is not getting approved. Compute sheet and verify sheet is working. but when i am proceeding further(i.e. approving sheet) some error comes. whatz wrong?

[Amit Parik (amit-parik)]

Hello Kaveri das,

Which type of error you have faced?
would you please provide the error detail ?

Thanks

[Amit Parik (amit-parik)]

Hello,

If you faced the traceback then would you please provide me the whole traceback.

Thanks.

[Kaveri Das (kaveri-das)]

Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/netsvc.py", line 489, in dispatch
    result = ExportService.getService(service_name).dispatch(method, auth, params)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/service/web_services.py", line 599, in dispatch
    res = fn(db, uid, *params)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/osv.py", line 122, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/osv.py", line 196, in exec_workflow
    res = self.exec_workflow_cr(cr, uid, obj, method, *args)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/osv.py", line 189, in exec_workflow_cr
    return wf_service.trg_validate(uid, obj, args[0], method, cr)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/wkf_service.py", line 80, in trg_validate
    res2 = instance.validate(cr, id, ident, signal)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/instance.py", line 48, in validate
    workitem.process(cr, witem, ident, signal, force_running, stack=stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 61, in process
    ok = _split_test(cr, workitem, activity['split_mode'], ident, signal, stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 174, in _split_test
    _join_test(cr, t[0], t[1], ident, stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 182, in _join_test
    create(cr,[activity], inst_id, ident, stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 41, in create
    process(cr, res, ident, stack=stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 53, in process
    result = _execute(cr, workitem, activity, ident, stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 107, in _execute
    wkf_expr.execute(cr, ident, workitem, activity)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/wkf_expr.py", line 68, in execute
    return _eval_expr(cr, ident, workitem, activity['action'])
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/wkf_expr.py", line 58, in _eval_expr
    ret = eval(line, env, nocopy=True)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/tools/safe_eval.py", line 281, in safe_eval
    return eval(test_expr(expr,_SAFE_OPCODES, mode=mode), globals_dict, locals_dict)
  File "", line 1, in <module>
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/orm.py", line 181, in <lambda>
    return lambda *args, **argv: attr(self._cr, self._uid, [self._id], *args, **argv)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/hr_payroll_account/hr_payroll_account.py", line 485, in verify_sheet
    move_line_id = movel_pool.create(cr, uid, line, context=context)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/account/account_move_line.py", line 1219, in create
    if ('...

[Kaveri Das (kaveri-das)]

Hello Amit,
           Is there any bug in the process of approving payslips?

[Amit Parik (amit-parik)]

Hello Kaveri Das,

I have tested your scenario with the trunk and stable 6.0 at my end.
But all are working fine.

I am agree with you. This type of traceback we did faced before but now it is working fine .
Therefore this problem is fixed in current latest code of trunk and stable 6.0 both.

So please update your code with simply using -u (Modules name) and -d (Database name).

Now I am closing this bug. If you still face the problem then you can reopen it.

Thanks.

[Kaveri Das (kaveri-das)]

Thank you Amit for your kind guidance.

[Kaveri Das (kaveri-das)]

Hello sir,
           After updation also i am facing the same problem. my payslips are not getting approved. some error comes

[Amit Parik (amit-parik)]

Hello Kaveri Das,

Please check it again with the new database.

Thanks.

[Kaveri Das (kaveri-das)]

Sir i have checked it in a new database. my problem didn't get solved. error comes. pls help me sir

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Kaveri,

I just reproduced the same.

This error can be faced only due to one of the following reasons:
1. There is no configuration parameter(We call it property) defined for Salary account of an employee.
-- Go Through Administration/Configuration/Parameters/Configuration Parameters and find for salary account.

2. If there is a property, the salary account does not exist.

Hope this helps.
Thanks.

[Kaveri Das (kaveri-das)]

Ok sir. will check that and let you know

[Kaveri Das (kaveri-das)]

Sir there is no such property for salary account. So next what i need to do?

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Kaveri,

If there is no property, so the problem exists.

Attached screenshot would ease your worries.

Thanks.

[Kaveri Das (kaveri-das)]

Thank you sir for guiding so well. But feeling bad as still i am not succeeding. i am attaching a screenshot. Sir can you pls guide me further so that my problem gets sorted out

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Kaveri,

Is it possible for you to send a dump of your database(if you are not using live)?

I doubt about the recency of the code you use.

Thanks.

[Kaveri Das (kaveri-das)]

ok sir. will surely sent you on saturday. thank you for your kind assistance

[Kaveri Das (kaveri-das)]

Hello Sir,
         I am attaching a dump database for your reference. Kindly let me know where i am wrong and for what the error comes.
Thank You

[Kaveri Das (kaveri-das)]

Hello Sir,
             Have you gone through my database?

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Kaveri,

After configuring Salary Account as a property, your first phase was clear.
The second error comes from unavailability of configuration for 'Employee Account' property.

The attached screenshot would help you configuring the another property.
Thank you.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Kaveri,

Thanks for the report actually.

This has made us aware about the unavailability of these fields in the employee form.
If these fields are on the Employee Form, one could easily configure.

Either way, there should be a notification that 'Basic configuration' is missing.

Thanks again.

[Ashvin Rathod (OpenERP) (ara-tinyerp)]

Hello Kaveri Das,

I have fixed the problem in lp:~openerp-dev/openobject-addons/trunk-bug-718741-ara branch, It will be merged soon with openobject-addons

Revision ID: <email address hidden>
Revision No: 4461

Thank you,
ara

[Kaveri Das (kaveri-das)]

Hello Sir,
       Thank you so much for considering and solving my problem

[Jay Vora (Serpent Consulting Services) (jayvora)]

Thanks Kaveri,Ashwin and Mustufa,

It has been fixed correctly in stable 6.0.1.

Thanks again.

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

yes jay,

I seen your merge proposal with XRG suggestions.

Thanks we will improve it in trunk.
mra