Document FileStore design, add some polish
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Dmedia |
Fix Released
|
High
|
Jason Gerard DeRose |
Bug Description
The dmedia.
On the design, I need to document:
1) Decision to use base32-encoded document IDs and how that relates to FileStore
2) Decision to include a file extension in the canonical filenames
3) More clearly explain security considerations of FileStore design
I'm also going to reorder the FileStore methods to make things clearer, will reorder into:
1) methods used to prevent path traversal outside of FileStore.base
2) methods for dealing with files inside the filestore, testing if files are inside filestore
3) methods for dealing with the temporary files used to stage new files to be placed in the filestore
And probably some other cleanup that hasn't come to mind
Related branches
- dmedia Dev: Pending requested
-
Diff: 810 lines (+438/-143)3 files modifieddmedia/filestore.py (+289/-77)
dmedia/schema.py (+2/-2)
dmedia/tests/test_filestore.py (+147/-64)
Changed in dmedia: | |
status: | In Progress → Fix Committed |
Changed in dmedia: | |
status: | Fix Committed → Fix Released |