Split FileStore.finalize_transfer() into simpler methods
Bug #717552 reported by
Jason Gerard DeRose
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Dmedia |
Fix Released
|
High
|
Jason Gerard DeRose |
Bug Description
Work on the BitTorrent downloader in lp:708418 has brought to light several places where the FileStore API needs tweaks to better fit what the backends need.
For lp:708418, I added the FileStore.
FileStore.
FileStore.
Pretty simple change, so I'll just explain details in docstrings.
This must be completed prior to lp:717544
Related branches
lp:~jderose/dmedia/filestore-tmp-api
- James Raymond: Approve
- dmedia Dev: Pending requested
-
Diff: 582 lines (+250/-66)4 files modifieddmedia/downloader.py (+2/-2)
dmedia/filestore.py (+119/-42)
dmedia/tests/test_downloader.py (+1/-1)
dmedia/tests/test_filestore.py (+128/-21)
description: | updated |
Changed in dmedia: | |
status: | In Progress → Fix Committed |
Changed in dmedia: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Okay, ready for review. Rather than "rename", I decided to go with clearer/shorter "move":
FileStore. tmp_move( tmp_fp, chash, ext) tmp_verify_ move(chash, ext)
FileStore.
While at it, I also renamed:
FileStore.reltemp() => FileStore.reltmp()
FileStore.temp() => FileStore.tmp()
https:/ /code.launchpad .net/~jderose/ dmedia/ filestore- tmp-api/ +merge/ 49495