C style casts

[Olaf van der Spek]

C casts shouldn't be used in C++, so -Wold-style-cast might be handy.

[Monty Taylor (mordred)]

Agree... and I welcome patches to fix the tree in this manner. For now, I suggest:

make CPPFLAGS='-Wold-style-cast'

To trigger places to find and fix. We can't add it to the official list of warnings yet, as there are THOUSANDS of them.

[Stewart Smith (stewart)]

On Fri, 11 Feb 2011 19:26:43 -0000, Monty Taylor <email address hidden> wrote:
> Agree... and I welcome patches to fix the tree in this manner. For now,
> I suggest:
>
> make CPPFLAGS='-Wold-style-cast'
>
> To trigger places to find and fix. We can't add it to the official list
> of warnings yet, as there are THOUSANDS of them.

do we have a Jenkins target with all these nice-to-haves on and the
warnings tracker thing on?

--
Stewart Smith

[Monty Taylor (mordred)]

Yup. That would be drizzle-build-all-warnings

"Stewart Smith" <email address hidden> wrote:

>On Fri, 11 Feb 2011 19:26:43 -0000, Monty Taylor <email address hidden>
>wrote:
>> Agree... and I welcome patches to fix the tree in this manner. For
>now,
>> I suggest:
>>
>> make CPPFLAGS='-Wold-style-cast'
>>
>> To trigger places to find and fix. We can't add it to the official
>list
>> of warnings yet, as there are THOUSANDS of them.
>
>do we have a Jenkins target with all these nice-to-haves on and the
>warnings tracker thing on?
>
>--
>Stewart Smith
>
>--
>You received this bug notification because you are a member of Drizzle-
>developers, which is subscribed to Drizzle.
>https://bugs.launchpad.net/bugs/717279
>
>Title:
> C style casts
>
>Status in A Lightweight SQL Database for Cloud Infrastructure and Web
>Applications:
> New
>
>Bug description:
> C casts shouldn't be used in C++, so -Wold-style-cast might be handy.

--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.