get_record_sql() breaks when the SQL contains a LIMIT

Bug #716533 reported by Matt Oquist
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
François Marier

Bug Description

It would be nice if get_record_sql() allowed queries that use ORDER BY and LIMIT 1 to ensure that the desired record is returned. Currently, queries with LIMIT break get_record_sql().

I tested a fresh installation of 1.4.0alpha2dev with this patch and everything seemed to be fine.

Revision history for this message
Matt Oquist (moquist) wrote :
Revision history for this message
François Marier (fmarier) wrote :

Looks good to me. Thanks Matt!

I've run the Selenium tests and they are just as broken with and without that patch, so that's as good as it gets :)

Changed in mahara:
milestone: none → 1.4.0
assignee: nobody → François Marier (fmarier)
importance: Undecided → Low
status: New → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.