Linaro Image Tools

populate_boot() should be moved to BoardConfig

Bug #716469 reported by Guilherme Salgado
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro Image Tools
Fix Released
Low
Loïc Minier
Linaro Image Tools 0.4.4

Bug Description

That function already uses BoardConfig.make_boot_files() to perform board-specific setup of the boot files, but now we have boards (https://code.launchpad.net/~angus-akkea/linaro-image-tools/Samsung-SMDKV310/+merge/49159) that need to skip most of what is done in populate_boot(), so it'd make sense to move it to BoardConfig and have it overwritten in subclasses that want different behavior.

Related branches

lp:~lool/linaro-image-tools/move-populate-boot
Guilherme Salgado (community): Approve
Diff: 320 lines (+63/-90)
4 files modified
linaro-media-create (+3/-4)
linaro_image_tools/media_create/boards.py (+57/-24)
linaro_image_tools/media_create/populate_boot.py (+0/-58)
linaro_image_tools/media_create/tests/test_media_create.py (+3/-4)
lp:linaro-image-tools/11.11
Loïc Minier (lool)
Changed in linaro-image-tools:
importance: Undecided → Low
status: New → Triaged
Loïc Minier (lool)
Changed in linaro-image-tools:
milestone: none → 0.4.4
Revision history for this message
Guilherme Salgado (salgado) wrote :

This would be a nice refactoring but I'm not sure it needs to happen before we can cut a 0.4.4 release

Loïc Minier (lool)
Changed in linaro-image-tools:
assignee: nobody → Loïc Minier (lool)
status: Triaged → In Progress
Loïc Minier (lool)
Changed in linaro-image-tools:
status: In Progress → Fix Committed
Mattias Backman (mabac)
Changed in linaro-image-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.