SchoolTool Intervention

Crashes for New Message, New Goal, New Status Message in the Student Intervention Center

Bug #716455 reported by Douglas Cerna
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SchoolTool Intervention
Fix Released
Critical
Alan Elkner
SchoolTool Intervention 0.4.3 "natty-updates"

Bug Description

Steps:

1. Check out schooltool trunk
2. Add schooltool.intervention to buildout.cfg
3. Create and run instance
4. Log in as manager
5. Create two persons
6. Create school year, term, course, section
7. Add one person as section teacher and one as section student
8. Get to the intervention center page for the student
9. After you hit New Message, New Goal or New Status Message you get:

Exception

  IndexError: string index out of range
Traceback

  File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.publisher-3.12.6-py2.6.egg/zope/publisher/publish.py", line 129, in publish
  obj = request.traverse(obj)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.publisher-3.12.6-py2.6.egg/zope/publisher/browser.py", line 540, in traverse
  ob = super(BrowserRequest, self).traverse(obj)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.publisher-3.12.6-py2.6.egg/zope/publisher/http.py", line 457, in traverse
  ob = super(HTTPRequest, self).traverse(obj)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.publisher-3.12.6-py2.6.egg/zope/publisher/base.py", line 260, in traverse
  obj = publication.traverseName(self, obj, entry_name)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.app.publication-3.12.0-py2.6.egg/zope/app/publication/zopepublication.py", line 194, in traverseName
  ob2 = ob.publishTraverse(request, nm)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.browserpage-3.12.2-py2.6.egg/zope/browserpage/metaconfigure.py", line 278, in publishTraverse
  view = queryMultiAdapter((self, request), name=name)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.component-3.9.5-py2.6.egg/zope/component/_api.py", line 120, in queryMultiAdapter
  return sitemanager.queryMultiAdapter(objects, interface, name, default)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.component-3.9.5-py2.6.egg/zope/component/registry.py", line 238, in queryMultiAdapter
  objects, interface, name, default)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.interface-3.6.1-py2.6-linux-x86_64.egg/zope/interface/adapter.py", line 532, in queryMultiAdapter
  result = factory(*objects)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/schooltool.intervention-0.4.2dev_r265-py2.6.egg/schooltool/intervention/browser/intervention.py", line 596, in __init__
  super(InterventionMessageAddView, self).__init__(context, request)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.app.form-4.0.2-py2.6.egg/zope/app/form/browser/editview.py", line 62, in __init__
  self._setUpWidgets()
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.app.form-4.0.2-py2.6.egg/zope/app/form/browser/add.py", line 48, in _setUpWidgets
  setUpWidgets(self, self.schema, IInputWidget, names=self.fieldNames)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.formlib-4.0.5-py2.6.egg/zope/formlib/utility.py", line 139, in setUpWidgets
  context=context)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.formlib-4.0.5-py2.6.egg/zope/formlib/utility.py", line 83, in setUpWidget
  widget = _createWidget(context, field, viewType, view.request)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.formlib-4.0.5-py2.6.egg/zope/formlib/utility.py", line 51, in _createWidget
  return component.getMultiAdapter((field, request), viewType)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.component-3.9.5-py2.6.egg/zope/component/_api.py", line 107, in getMultiAdapter
  adapter = queryMultiAdapter(objects, interface, name, context=context)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.component-3.9.5-py2.6.egg/zope/component/_api.py", line 120, in queryMultiAdapter
  return sitemanager.queryMultiAdapter(objects, interface, name, default)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.component-3.9.5-py2.6.egg/zope/component/registry.py", line 238, in queryMultiAdapter
  objects, interface, name, default)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.interface-3.6.1-py2.6-linux-x86_64.egg/zope/interface/adapter.py", line 532, in queryMultiAdapter
  result = factory(*objects)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/zope.component-3.9.5-py2.6.egg/zope/component/zcml.py", line 546, in __call__
  return proxify(self.factory(*objects), self.checker)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/schooltool.intervention-0.4.2dev_r265-py2.6.egg/schooltool/intervention/browser/widgets.py", line 149, in __init__
  value = intervention.convertIdToName(choice)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/schooltool.intervention-0.4.2dev_r265-py2.6.egg/schooltool/intervention/intervention.py", line 101, in convertIdToName
  sort, name = convertIdToNameWithSort(id)
File "/home/replaceafill/.sandboxes/schooltool_docs/eggs/schooltool.intervention-0.4.2dev_r265-py2.6.egg/schooltool/intervention/intervention.py", line 78, in convertIdToNameWithSort
  if id[-2] == ':':

Related branches

lp:~aelkner/schooltool.intervention/test_coverage
Gediminas Paulauskas (community): Approve
Justas Sadzevičius (community): Approve
Diff: 6495 lines (+2989/-1802)
48 files modified
CHANGES.txt (+4/-1)
buildout.cfg (+1/-0)
setup.py (+0/-1)
src/schooltool/intervention/README.txt (+106/-157)
src/schooltool/intervention/adapters.py (+225/-0)
src/schooltool/intervention/adapters.zcml (+86/-0)
src/schooltool/intervention/browser/configure.zcml (+15/-15)
src/schooltool/intervention/browser/ftesting.zcml (+29/-3)
src/schooltool/intervention/browser/ftests/README.txt (+410/-505)
src/schooltool/intervention/browser/ftests/__init__.py (+1/-0)
src/schooltool/intervention/browser/ftests/ftests.py (+73/-2)
src/schooltool/intervention/browser/ftests/independent_activities.txt (+94/-0)
src/schooltool/intervention/browser/ftests/intervention_dashboard.txt (+414/-0)
src/schooltool/intervention/browser/ftests/no_current_term.txt (+24/-2)
src/schooltool/intervention/browser/ftests/removal_subscribers.txt (+49/-0)
src/schooltool/intervention/browser/ftests/security.txt (+1/-1)
src/schooltool/intervention/browser/intervention.py (+88/-75)
src/schooltool/intervention/browser/reports.py (+0/-54)
src/schooltool/intervention/browser/templates/intervention_students.pt (+8/-10)
src/schooltool/intervention/browser/templates/no_current_term.pt (+19/-0)
src/schooltool/intervention/browser/templates/person_list.pt (+4/-3)
src/schooltool/intervention/browser/widgets.py (+68/-60)
src/schooltool/intervention/catalog.py (+50/-39)
src/schooltool/intervention/catalog.zcml (+48/-0)
src/schooltool/intervention/configure.zcml (+9/-167)
src/schooltool/intervention/generations/__init__.py (+2/-2)
src/schooltool/intervention/generations/evolve1.py (+8/-4)
src/schooltool/intervention/generations/evolve5.py (+4/-23)
src/schooltool/intervention/generations/evolve7.py (+112/-0)
src/schooltool/intervention/generations/evolve8.py (+56/-0)
src/schooltool/intervention/generations/tests/__init__.py (+18/-0)
src/schooltool/intervention/generations/tests/test_evolve1.py (+9/-5)
src/schooltool/intervention/generations/tests/test_evolve5.py (+0/-108)
src/schooltool/intervention/generations/tests/test_evolve7.py (+215/-0)
src/schooltool/intervention/generations/tests/test_evolve8.py (+118/-0)
src/schooltool/intervention/gradebook_integration.py (+26/-0)
src/schooltool/intervention/gradebook_integration.zcml (+15/-0)
src/schooltool/intervention/interfaces.py (+16/-17)
src/schooltool/intervention/intervention.py (+69/-373)
src/schooltool/intervention/intervention.zcml (+73/-0)
src/schooltool/intervention/security.py (+113/-0)
src/schooltool/intervention/security.zcml (+4/-4)
src/schooltool/intervention/sendmail.py (+52/-25)
src/schooltool/intervention/tests/test_catalog.py (+198/-60)
src/schooltool/intervention/tests/test_intervention.py (+6/-6)
src/schooltool/intervention/tests/tests.py (+39/-0)
src/schooltool/intervention/traversal.py (+10/-3)
src/schooltool/intervention/vocabularies.py (+0/-77)
Douglas Cerna (replaceafill)
Changed in schooltool.intervention:
assignee: nobody → Alan Elkner (aelkner)
importance: Undecided → Critical
Revision history for this message
Alan Elkner (aelkner) wrote :

If the user id is a single character (something that no non-developer is likely to do), it crashes, so I will fix it.

Changed in schooltool.intervention:
status: New → Confirmed
Alan Elkner (aelkner)
Changed in schooltool.intervention:
status: Confirmed → Fix Committed
Gediminas Paulauskas (menesis)
Changed in schooltool.intervention:
milestone: none → 0.4.3
Gediminas Paulauskas (menesis)
Changed in schooltool.intervention:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.