collective.buildout

plone.recipe.zope2instance: include-site-packages hardcoded

Bug #716360 reported by yuppie
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
collective.buildout
Fix Released
Undecided
Unassigned

Bug Description

zc.buildout 1.5 has an 'include-site-packages' buildout option that is *true* by default. plone.recipe.zope2instance uses a hardcoded *false*. That is not backwards compatible with zc.buildout 1.4 behavior: Windows buildouts that depend on pywin32 installed in site-packages don't work with zc.buildout 1.5.2 and plone.recipe.zope2instance 4.1.4.

Proposed solution: Respect 'include-site-packages' settings and the default from zc.buildout. See patch.

Maybe other options like 'exec_sitecustomize' should be respected as well. And maybe the lookup should be delegated to z3c.recipe.scripts.scripts.Base as in z3c.recipe.i18n:
http://svn.zope.org/z3c.recipe.i18n/trunk/src/z3c/recipe/i18n/i18n.py?rev=117252&view=auto

Revision history for this message
yuppie (yuppie3) wrote :
Revision history for this message
Hanno Schlichting (hannosch) wrote :

Thanks for the patch, applied and fix released in 4.1.5

Changed in collective.buildout:
assignee: nobody → Hanno Schlichting (hannosch)
assignee: Hanno Schlichting (hannosch) → nobody
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.