Glance Code Cleanup Round 1
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Glance |
Fix Released
|
Low
|
Rick Harris |
Bug Description
We have a few blemishes in the code-base that would be worth excising:
1. glance/
2. glance/common/db is empty, we can ax this
3. Django-community gripe caught my attention:
Rick-Harriss-
./glance/
./glance/util.py
./tests/utils.py
I prefer utils, so I vote we rename glance/util -> glance/utils.py
4. ./run_tests -N is now producing tons of log messages even when it succeeds. We should probably silence that.
5. README is a little out of date, we can probably put something a little more useful in there.
6. tests/functional is empty. I vote we remove this directory and add back once we have a functional test. The counter-arg here is that this will gnaw at us so that we actually write a functional test. I don't buy it :)
Related branches
- Rick Harris (community): Needs Resubmitting
- Jay Pipes (community): Needs Fixing
- Devin Carlen (community): Approve
-
Diff: 332 lines (+81/-77)9 files modifiedREADME (+46/-9)
glance/client.py (+5/-5)
glance/common/db/__init__.py (+0/-22)
glance/server.py (+7/-7)
glance/store/backends/__init__.py (+0/-16)
run_tests.sh (+2/-1)
tests/stubs.py (+9/-7)
tests/unit/test_api.py (+6/-5)
tests/unit/test_migrations.py (+6/-5)
Changed in glance: | |
assignee: | nobody → Rick Harris (rconradharris) |
importance: | Undecided → Low |
Changed in glance: | |
status: | New → Fix Committed |
Changed in glance: | |
milestone: | none → 2011.2 |
status: | Fix Committed → Fix Released |