handlersocket does not compile against MariaDB 5.3

[Philip Stoev]

Even after working around bug 712714 , handlersocket does not compile against maria-5.3

To repeat, configure handlersocket

 ./configure --with-mysql-source=/home/philips/bzr/mysql-5.3.0-MariaDB-alpha --with-mysql-bindir=/home/philips/bzr/maria-5.3-bintar/bin/

then run "make" and you will get

/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ‘void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)’:
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ‘virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)’ is protected
database.cpp:793: error: within this context
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ‘virtual int handler::index_prev(uchar*)’ is protected
database.cpp:798: error: within this context
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ‘virtual int handler::index_next(uchar*)’ is protected
database.cpp:802: error: within this context
/home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ‘virtual int handler::index_next_same(uchar*, const uchar*, uint)’ is protected
database.cpp:805: error: within this context
make[2]: *** [handlersocket_la-database.lo] Error 1

[Sergei Golubchik (sergii)]

Hi, Philip!

we have a plug.in file for handlersocket that allows to build it from
within the source tree. It solves this problem.

On Feb 03, Philip Stoev wrote:
> Public bug reported:
>
> Even after working around bug 712714 , handlersocket does not compile
> against maria-5.3
>
> To repeat, configure handlersocket
>
> ./configure --with-mysql-source=/home/philips/bzr/mysql-5.3.0-MariaDB-
> alpha --with-mysql-bindir=/home/philips/bzr/maria-5.3-bintar/bin/
>
> then run "make" and you will get
>
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ???void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)???:
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ???virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)??? is protected
> database.cpp:793: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ???virtual int handler::index_prev(uchar*)??? is protected
> database.cpp:798: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ???virtual int handler::index_next(uchar*)??? is protected
> database.cpp:802: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1829: error: ???virtual int handler::index_next_same(uchar*, const uchar*, uint)??? is protected
> database.cpp:805: error: within this context
> make[2]: *** [handlersocket_la-database.lo] Error 1
>
> ** Affects: maria
> Importance: Undecided
> Status: New
>
> ** Changed in: maria
> Milestone: None => 5.3
>
> ** Branch linked: lp:~maria-captains/maria/5.3-handler
>
> --
> You received this bug notification because you are a member of Maria-
> captains, which is the registrant for Maria.
> https://bugs.launchpad.net/bugs/712720
>
> Title:
> handlersocket does not compile against MariaDB 5.3
>
> Status in Maria:
> New
>
> Bug description:
> Even after working around bug 712714 , handlersocket does not compile
> against maria-5.3
>
> To repeat, configure handlersocket
>
> ./configure --with-mysql-source=/home/philips/bzr/mysql-5.3.0
> -MariaDB-alpha --with-mysql-
> bindir=/home/philips/bzr/maria-5.3-bintar/bin/
>
> then run "make" and you will get
>
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h: In member function ???void dena::dbcontext::cmd_find_internal(dena::dbcallback_i&, const dena::prep_stmt&, ha_rkey_function, const dena::cmd_exec_args&)???:
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1805: error: ???virtual int handler::index_read_map(uchar*, const uchar*, key_part_map, ha_rkey_function)??? is protected
> database.cpp:793: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1823: error: ???virtual int handler::index_prev(uchar*)??? is protected
> database.cpp:798: error: within this context
> /home/philips/bzr/mysql-5.3.0-MariaDB-alpha/sql/handler.h:1821: error: ???virtual int handler::index_next(uchar*)??? is protected
> database.cpp:802: error: within this contex...

[Philip Stoev (philip-stoev)]

I think we should still provide a patch for the main handlersocket tree so that it compiles properly with MariaDB.

[Sergei Golubchik (sergii)]

plug.in file and all necessary changes

[Philip Stoev (pstoev-askmonty)]

Patch does not work against the latest handlersocket:

|diff -ru plugin/ahiguti-HandlerSocket-Plugin-for-MySQL-34cb96a/handlersocket/database.cpp plugin/HandlerSocket/handlersocket/database.cpp
|--- plugin/ahiguti-HandlerSocket-Plugin-for-MySQL-34cb96a/handlersocket/database.cpp 2011-01-01 23:59:13.000000000 +0100
|+++ plugin/HandlerSocket/handlersocket/database.cpp 2011-01-04 15:05:04.000000000 +0100
--------------------------
File to patch: handlersocket/database.cpp
patching file handlersocket/database.cpp
Hunk #1 succeeded at 790 (offset 11 lines).
patching file Makefile.am
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 7.
2 out of 2 hunks FAILED -- saving rejects to file Makefile.am.rej
patching file plug.in

[Philip Stoev (pstoev-askmonty)]

nevermind it worked with -p2

[Philip Stoev (pstoev-askmonty)]

If -Werror is enabled, as it is by the ./BUILD/compile-pentium-debug-max-no-ndb script, we get:

(13:29:42) philip_stoev1: "cc1plus: warnings being treated as errors
(13:29:42) philip_stoev1: In file included from socket.hpp:15,
(13:29:42) philip_stoev1: from socket.cpp:18:
(13:29:42) philip_stoev1: auto_addrinfo.hpp: In member function ‘int dena::auto_addrinfo::resolve(const char*, const char*, int, int, int, int)’:
(13:29:42) philip_stoev1: auto_addrinfo.hpp:35: error: missing initializer for member ‘addrinfo::ai_flags’"

[Jason (jsia18)]

Hi,

Where can I find the plug.in file and instructions on how to patch it. I'm trying to build it against mariadb 5.2.5 and I am receiving the same error.

Thanks

[Sergei Golubchik (sergii)]

Hi, Jason!

On Apr 18, Jason wrote:
> Hi,
>
> Where can I find the plug.in file and instructions on how to patch it.
> I'm trying to build it against mariadb 5.2.5 and I am receiving the same
> error.

See, the bug report has "Status: Fix Committed", and "Milestone: Maria 5.3".
Which means, you can find the files in 5.3 mariadb tree.

http://bazaar.launchpad.net/~maria-captains/maria/5.3/files

Regards,
Sergei