Some font names are unreadable in animated title editor

[IRIE Shinsuke]

Font selector in the animated title editor uses PIL's ImageFont module since r442. However, it extracts the font names from .ttf files regardless of current locale and assumes the names contain only ASCII characters, so some fonts having only multibyte name become unreadable in the dropdown menu. (See screenshot)

[IRIE Shinsuke (irie)]

I wrote a patch for this issue. By applying this patch, the font selector uses 'fc-list' command instead of ImageFont module, and should correctly show the font names according to current locale.

[IRIE Shinsuke (irie)]

Screenshot after applying my patch.

[Olivier Girard (eolinwen)]

That's right that's better. :)
Thanks a lot.

[IRIE Shinsuke (irie)]

@cenwen
The change isn't committed to trunk yet. I wonder why you changed the status into "Fix Committed"...

[Olivier Girard (eolinwen)]

It is an error(?) of translation/appreciation that i am doing between Fix Committed and Fix Released.
In my mind it is :
Committed=submit waiting to an acceptance
Released=Accepted and put in the trunk
Is it the opposite ? How do you understand that you ?

[IRIE Shinsuke (irie)]

I think :

Fix Committed = Accepted and put in the trunk
Fix Released = Included in stable (or beta) version

and "Submit waiting to an acceptance" is a last stage of "In Progress".

For example, in bug #670960, Jonathan changed the status into "Fix Committed" when he put the modification to trunk.

[Olivier Girard (eolinwen)]

Ah Funny. I have always think that was in progression.
Thanks for the explanations.

[Jonathan Thomas (jonoomph)]

Thanks IRIE! The patch works great. My only hesitation with this patch is it adds a new dependency to OpenShot... "fontconfig". I don't know much about this library, but it seems pretty common. So, I updated our help manual to include this new dependency, and committed the patch to the trunk.

[IRIE Shinsuke (irie)]

> I don't know much about this library, but it seems pretty common.

Yeah, 'fontconfig' package is required by GTK+, so it should be installed even if not specifying explicitly.