MVHub

add test coverage for MVHub::Common::display_agency_home_page_and_exit()

Bug #711592 reported by Dan MacNeil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MVHub
Confirmed
Medium
frank allaby

Bug Description

Add a .t file in the appropriate place

You can reduce test complexity by modifying display_agency_home_page_and_exit()
to use Params::Validate for the required parameters.

Related branches

lp:~fallaby/mvhub/display_agency_home_page_and_exit
MVHub devs with commit rights: Pending requested
Diff: 70 lines (+15/-8)
3 files modified
app-mvhub/doc/cheat_sheets/bzr_workflow.txt (+2/-2)
lib-mvhub/lib/MVHub/Common.pm (+13/-5)
lib-mvhub/t/AgencyFieldDefs/get_agency_field_definitions_href.t (+0/-1)
Dan MacNeil (omacneil)
Changed in mvhub:
importance: Undecided → Medium
status: New → Confirmed
assignee: nobody → frank allaby (fallaby)
Revision history for this message
frank allaby (fallaby) wrote :

I have a solution for a test of this sub. It's convoluted but it works. If you find time to review for merge, I can send it to you.

Revision history for this message
Dan MacNeil (omacneil) wrote :

If you submit a merge request, I will review it. Certainly within a week, I'd shoot for 1-2 days.

Generally, I'll listen politely but reject anything that requires any hand work or hard coding of variables. if it isn't a .t file and / or it doesn't run with prove, odds are against it.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.