Odoo Addons (MOVED TO GITHUB)

[webkit] Descriptions don't get translated

Bug #710061 reported by Joke de Buhr on 2011-01-30

This bug affects 4 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Low	OpenERP Publisher's Warranty Team	Odoo Addons (MOVED TO GITHUB) 6.0.3

Bug Description

Descriptions like "Supplier Invoice", "Invoice Date" or "Price" don't get translated. The customer language is set correctly.

Every description on the sample report is transfered to the output exactly as it appears within the .mako file. Database translations don't get fetched apparently. The database translations are stored under field name "addons/report_webkit_sample/report/report_webkit_html.mako". This may be wrong.

Openerp: 6.0.1
Webkit: 6.0.0.9
Webkit sample: 6.0.0.9

Tags:

Related branches

lp:~openerp-dev/openobject-addons/6.0-opw-5770-ach

Merged into lp:openobject-addons/6.0 at revision 4655

Jay Vora (Serpent Consulting Services) (community): Approve on 2011-06-16

Riken Bhorania (OpenERP) (community): Approve on 2011-06-10

Revision history for this message

Azazahmed Saiyed (OpenERP) (saz-openerp) wrote on 2011-02-02:

Hello,

I have checked the issue by setting the user language as Germany and the output reflected in pdf report remains untranslated.

I have attached the pdf for the reference, So I am confirming this bug.

Thanks.

affects:	openobject-addons → openobject-server
Changed in openobject-server:
assignee:	nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance:	Undecided → Low
status:	New → Confirmed

Revision history for this message

Azazahmed Saiyed (OpenERP) (saz-openerp) wrote on 2011-02-02:

openerp_rbTB42.pdf Edit (26.6 KiB, application/pdf)

gpa(OpenERP) (gpa-openerp) on 2011-02-04

Changed in openobject-server:
status:	Confirmed → In Progress

Revision history for this message

Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote on 2011-03-08:

Hello,

It appears that the bug does not come directly from webkit_report but from the mechanism that update po that give invalid name for ir.translation line.

Regards

Nicolas

Anup(SerpentCS) (anup-serpent) on 2011-05-17

Changed in openobject-server:
status:	In Progress → Confirmed
assignee:	OpenERP's Framework R&D (openerp-dev-framework) → Anup(OpenERP) (ach-openerp)
assignee:	Anup(OpenERP) (ach-openerp) → OpenERP Publisher's Warranty Team (openerp-opw)

Anup(SerpentCS) (anup-serpent) on 2011-05-17

tags:

added: maintenance

Revision history for this message

Anup(SerpentCS) (anup-serpent) wrote on 2011-05-19:

Hello,

The issue has been fixed by revision 4594 <email address hidden> in the branch lp:~openerp-dev/openobject-addons/6.0-opw-5770-ach.

It will be merged soon in the stable v6.

Thanks.

Changed in openobject-server:
status:	Confirmed → Fix Committed

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2011-06-16:

Hello Joke,

Thanks for reporting, it has been fixed into stable 6.0 by revision 4655 <email address hidden>.

Thanks.

Changed in openobject-server:
status:	Fix Committed → Fix Released
milestone:	none → 6.0.3
affects:	openobject-server → openobject-addons
Changed in openobject-addons:
milestone:	6.0.3 → none
milestone:	none → 6.0.3

Revision history for this message

Eric Christensen (eric-christensen) wrote on 2011-08-08:

Hello,

I have tested reporter_webkit 6.0.0.9 on oe 6.0.2 and as far as I can diagnose this patch kills the normal functionality of the setLang parameter in the report. Standard OE labels/text fields are no longer translated in line with the report definition.

Excerpt from the mako file:

<body>
    %for sod in objects :
        <% setLang(sod.partner_id.lang) %>
        This is my report langue : ${sod.partner_id.lang}

So the intention is to set the report language aligned with the partner's language.

With 6.0.0.9 where the only main change was (webkit_report.py):

@297
self.parser_instance.localcontext.update({'setLang':self.setLang})
self.parser_instance.localcontext.update({'formatLang':self.formatLang})

the result of this change is for example that the units of measure only returns the language value of the field in line with the preferred language of the user (so if user has NL then the result is NL, if en then en , etc). But not according to the partner's language.

Out comment the lines and the language setting works correctly. So if the test conditions were OK something was broken here.

Regards,
Eric