Drizzle

--engine in dbqp.py is broken

Bug #709646 reported by Vijay Samuel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Drizzle
Fix Released
Low
Patrick Crews
Drizzle 2011-02-28
7.0
Fix Released
Low
Patrick Crews
Drizzle 2011-02-28

Bug Description

python dbqp.py --engine=memory still runs innodb. providing invalid storage engine names also runs innodb. invalid storage engine names must throw errors and log them.

Related branches

lp:~patrick-crews/drizzle/dbqp_engine_and_repeat
Drizzle Developers: Pending requested
Diff: 188 lines (+49/-12)
7 files modified
docs/testing/dbqp.rst (+5/-0)
tests/dbqp.py (+4/-2)
tests/lib/server_mgmt/drizzled.py (+9/-2)
tests/lib/server_mgmt/server_management.py (+10/-2)
tests/lib/test_mgmt/execution_management.py (+1/-0)
tests/lib/test_mgmt/test_execution.py (+7/-5)
tests/lib/test_run_options.py (+13/-1)
Revision history for this message
Patrick Crews (patrick-crews) wrote :

Will rename to --default-storage-engine and will add code to handle this appropriately.
Option was largely a placeholder while I got the rest of the system working - thanks for the reminder! : )

Changed in drizzle:
status: New → Confirmed
assignee: nobody → Patrick Crews (patrick-crews)
importance: Undecided → Low
Patrick Crews (patrick-crews)
Changed in drizzle:
status: Confirmed → Fix Committed
milestone: none → 2011-02-14
Revision history for this message
Patrick Crews (patrick-crews) wrote :

Feature now works. We use a --default-storage-engine option for all server startups. We also report the value we are using.

Additionally, if the user supplies a bad option, the server startup will fail, the testcase will fail, it will be in the log. It would be hackish to try to catch this any other way (eg saying "Hey you tried to use a default engine that isn't available, we'll default to innodb, etc")- we'll let the server do the work and make the user provide sensible options that they actually want to use so we don't accidentally shield the server from any bugs.

Noting this in case the topic ever comes up ; )

Patrick Crews (patrick-crews)
Changed in drizzle:
milestone: 2011-02-14 → 2011-02-28
Lee Bieber (kalebral-deactivatedaccount)
Changed in drizzle:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.