associate floating ip address to an instance works without allocating address

[Tushar Patil]

Tested with Trunk revision No 606.

I created a floating addresses of range 10.2.3.0/24

I can associate floating ip addres 10.2.3.96 to an instance without allocating it for the project.

Expected Result: It should gives error message something like
"Floating ip address <IP address> is not allocated to project <AAA>"

[Vish Ishaya (vishvananda)]

are you an admin? Is the instance allocated to another project?

Vish

On Jan 26, 2011, at 1:37 PM, Tushar Patil wrote:

> Public bug reported:
>
> Tested with Trunk revision No 606.
>
> I created a floating addresses of range 10.2.3.0/24
>
> I can associate floating ip addres 10.2.3.96 to an instance without
> allocating it for the project.
>
> Expected Result: It should gives error message something like
> "Floating ip address <IP address> is not allocated to project <AAA>"
>
> ** Affects: nova
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are a member of Nova Bug
> Team, which is subscribed to OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/708320
>
> Title:
> associate floating ip address to an instance works without allocating
> address
>
> Status in OpenStack Compute (Nova):
> New
>
> Bug description:
> Tested with Trunk revision No 606.
>
> I created a floating addresses of range 10.2.3.0/24
>
> I can associate floating ip addres 10.2.3.96 to an instance without
> allocating it for the project.
>
> Expected Result: It should gives error message something like
> "Floating ip address <IP address> is not allocated to project <AAA>"
>
>

[Tushar Patil (tpatil)]

Yes, I am running euca-associate-address as admin.

No, the floating ip address is not allocated to any project.

[Vish Ishaya (vishvananda)]

Admin may bypass the allocated check. I don't think this works as a normal user and it probably shouldn't work as an admin either.
On Jan 26, 2011, at 3:05 PM, Tushar Patil wrote:

> Yes, I am running euca-associate-address as admin.
>
> No, the floating ip address is not allocated to any project.
>
> --
> You received this bug notification because you are a member of Nova Bug
> Team, which is subscribed to OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/708320
>
> Title:
> associate floating ip address to an instance works without allocating
> address
>
> Status in OpenStack Compute (Nova):
> New
>
> Bug description:
> Tested with Trunk revision No 606.
>
> I created a floating addresses of range 10.2.3.0/24
>
> I can associate floating ip addres 10.2.3.96 to an instance without
> allocating it for the project.
>
> Expected Result: It should gives error message something like
> "Floating ip address <IP address> is not allocated to project <AAA>"
>
>

[Masanori Itoh (itohm)]

Hi Tushar, Vish,

I think floating IP issue is more complicated.

One more thing is that at this moment all floating IPs (Elastic IPs for euca2ools users) are displayed by DescribeAddresses API call. But, I think we should suppress un-allocated floating IPs.

I created a bug fix branch to address the above issue and linked it to this bug report.

What do you think about?

-Masanori

[Tushar Patil (tpatil)]

You have a good point.
I think it is better you report a new bug and fix it.

[Vish Ishaya (vishvananda)]

> One more thing is that at this moment all floating IPs (Elastic IPs for euca2ools users) are displayed by DescribeAddresses API call. But, I think we should suppress un-allocated floating IPs.

It only shows all ips for admins. Regular users only see ips that have been allocated to the project. I don't think a fix is necessary.

[Masanori Itoh (itohm)]

Hi Vish,

OK. I will post another bug report soon.
Actually, I have some more issues on Floating IP/Elastic IP thing.
So, maybe bug report*s* and patch*es*. :)

Regards,
-Masanori

[Masanori Itoh (itohm)]

Oops. The above comment(#7) was for Tushar.

Vish,

> It only shows all ips for admins. Regular users only see ips that have been allocated to the project. I don't think a fix is necessary.

I alto think that in the case of the call by admin it's reasonable displaying all allocated floating/elastic IPs regardless of the owner.

My point is that only Floating IPs/Elastic IPs allocated by AllocateAddress call should be displayed.
In other word, DescribeAddresses call should not return any address without AllocateAddress calls in the case of EC2 API.

At this moment, all floating IPs are displayed even including network address and broadcast address by euca-describe addresses.

I know Floating IP and Elastic IP(or public IP) are different somehow, and I will check both cases.
Give me time a little bit.

Regards,

-Masanori

[Tushar Patil (tpatil)]

This bug is already fixed in revision 926. This bug status should be marked as Fix Committed.

[Masanori Itoh (itohm)]

> This bug is already fixed in revision 926. This bug status should be marked as Fix Committed.

Agreed.
I'm unlinking my branch and change the status.